Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Issue 12454003: Change test_isolation_mode default from noop to check (Closed)

Created:
7 years, 9 months ago by csharp
Modified:
7 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Change test_isolation_mode default from noop to check NOTRY=True TBR=maruel@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187575

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M build/common.gypi View 1 6 chunks +22 lines, -15 lines 0 comments Download
M build/isolate.gypi View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
csharp
7 years, 9 months ago (2013-03-11 16:58:23 UTC) #1
M-A Ruel
lgtm
7 years, 9 months ago (2013-03-11 17:01:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/12454003/1
7 years, 9 months ago (2013-03-12 13:23:24 UTC) #3
commit-bot: I haz the power
Failed to apply patch for build/isolate.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 9 months ago (2013-03-12 13:23:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/12454003/7001
7 years, 9 months ago (2013-03-12 13:27:39 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-12 13:27:57 UTC) #6
Message was sent while issue was closed.
Change committed as 187575

Powered by Google App Engine
This is Rietveld 408576698