Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.h

Issue 124533003: Add country combobox to change country and rebuild address inputs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.h
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.h b/chrome/browser/ui/views/autofill/autofill_dialog_views.h
index dbe4dd02c0d9ff4c4d75bbc987a019c95b756901..add20efc5d459daaf08ba36aac7b067fa0fb73f7 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.h
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.h
@@ -460,9 +460,9 @@ class AutofillDialogViews : public AutofillDialogView,
SectionContainer* container;
// The view that allows manual input.
views::View* manual_input;
- // The textfields in |manual_input|, tracked by their DetailInput.
+ // The textfields in |manual_input|, tracked by their ServerFieldType.
TextfieldMap textfields;
- // The comboboxes in |manual_input|, tracked by their DetailInput.
+ // The comboboxes in |manual_input|, tracked by their ServerFieldType.
ComboboxMap comboboxes;
// The view that holds the text of the suggested data. This will be
// visible IFF |manual_input| is not visible.
@@ -504,10 +504,8 @@ class AutofillDialogViews : public AutofillDialogView,
// a given section.
views::View* CreateInputsContainer(DialogSection section);
- // Creates a grid of textfield views for the given section, and stores them
- // in the appropriate DetailsGroup. The top level View in the hierarchy is
- // returned.
- views::View* InitInputsView(DialogSection section);
+ // Creates a grid of inputs for the given section.
+ void InitInputsView(DialogSection section);
// Changes the function of the whole dialog. Currently this can show a loading
// shield, an embedded sign in web view, or the more typical detail input mode
@@ -530,6 +528,9 @@ class AutofillDialogViews : public AutofillDialogView,
// Returns NULL if no DetailsGroup was found.
DetailsGroup* GroupForView(views::View* view);
+ // Erases all views in |group| from |validity_map_|.
+ void EraseInvalidViewsInGroup(const DetailsGroup* group);
+
// Explicitly focuses the initially focusable view.
void FocusInitialView();
@@ -579,6 +580,9 @@ class AutofillDialogViews : public AutofillDialogView,
// Gets the combobox view that is shown for the given |type|, or NULL.
views::Combobox* ComboboxForType(ServerFieldType type);
+ // Returns the associated ServerFieldType for |combobox|.
+ ServerFieldType TypeForCombobox(const views::Combobox* combobox) const;
+
// Called when the details container changes in size or position.
void DetailsContainerBoundsChanged();

Powered by Google App Engine
This is Rietveld 408576698