Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2614)

Unified Diff: base/process_util_win.cc

Issue 12453006: Add DPLOGs to base::LaunchProcess() failures on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util_win.cc
diff --git a/base/process_util_win.cc b/base/process_util_win.cc
index 2a47f130b69039d4c26e39325967658bcae4b7b8..2861d308912f80bb34fa6ca8a0b924991e231950 100644
--- a/base/process_util_win.cc
+++ b/base/process_util_win.cc
@@ -351,8 +351,10 @@ bool LaunchProcess(const string16& cmdline,
flags |= CREATE_UNICODE_ENVIRONMENT;
void* enviroment_block = NULL;
- if (!CreateEnvironmentBlock(&enviroment_block, options.as_user, FALSE))
+ if (!CreateEnvironmentBlock(&enviroment_block, options.as_user, FALSE)) {
+ DPLOG(ERROR);
return false;
+ }
BOOL launched =
CreateProcessAsUser(options.as_user, NULL,
@@ -361,13 +363,16 @@ bool LaunchProcess(const string16& cmdline,
enviroment_block, NULL, &startup_info,
process_info.Receive());
DestroyEnvironmentBlock(enviroment_block);
- if (!launched)
+ if (!launched) {
+ DPLOG(ERROR);
return false;
+ }
} else {
if (!CreateProcess(NULL,
const_cast<wchar_t*>(cmdline.c_str()), NULL, NULL,
options.inherit_handles, flags, NULL, NULL,
&startup_info, process_info.Receive())) {
+ DPLOG(ERROR);
return false;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698