Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 12453006: Add DPLOGs to base::LaunchProcess() failures on Windows. (Closed)

Created:
7 years, 9 months ago by gab
Modified:
7 years, 9 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add DPLOGs to base::LaunchProcess() failures on Windows. I have manually added logs here too many times already and I think it doesn't hurt to have them in the codebase permanently. R=willchan@chromium.org NOTRY=True BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M base/process_util_win.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gab
7 years, 9 months ago (2013-03-05 17:55:39 UTC) #1
willchan no longer on Chromium
lgtm
7 years, 9 months ago (2013-03-05 18:08:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/12453006/1
7 years, 9 months ago (2013-03-05 18:09:58 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 18:11:59 UTC) #4
Message was sent while issue was closed.
Change committed as 186200

Powered by Google App Engine
This is Rietveld 408576698