src/objects.cc - Issue 12451003: Make IC patching resilient to flushing of the original target() ic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 12451003: Make IC patching resilient to flushing of the original target() ic. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 8b26185b11cf5b8d258d0b8f2a6b33dd8eabeb71..dc645d328e3d0d17c216766935f07eacd7f2f73a 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -8804,7 +8804,7 @@ void Code::FindAllCode(CodeHandleList* code_list, int length) {

if (i++ == length) return;

RelocInfo* info = it.rinfo();

Code* code = Code::GetCodeFromTargetAddress(info->target_address());

- ASSERT(code->is_load_stub());

+ ASSERT(code->kind() == Code::STUB);

code_list->Add(Handle<Code>(code));

}

UNREACHABLE();

« no previous file with comments | « src/objects.h ('k') | src/objects-inl.h » ('j') | no next file with comments »