Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: src/x64/ic-x64.cc

Issue 12451003: Make IC patching resilient to flushing of the original target() ic. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/stub-cache.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1310 matching lines...) Expand 10 before | Expand all | Expand 10 after
1321 1321
1322 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) { 1322 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) {
1323 // ----------- S t a t e ------------- 1323 // ----------- S t a t e -------------
1324 // -- rax : receiver 1324 // -- rax : receiver
1325 // -- rcx : name 1325 // -- rcx : name
1326 // -- rsp[0] : return address 1326 // -- rsp[0] : return address
1327 // ----------------------------------- 1327 // -----------------------------------
1328 1328
1329 // Probe the stub cache. 1329 // Probe the stub cache.
1330 Code::Flags flags = Code::ComputeFlags( 1330 Code::Flags flags = Code::ComputeFlags(
1331 Code::LOAD_IC, MONOMORPHIC, Code::HANDLER_FRAGMENT); 1331 Code::STUB, MONOMORPHIC, Code::kNoExtraICState,
1332 Code::NORMAL, Code::LOAD_IC);
1332 Isolate::Current()->stub_cache()->GenerateProbe( 1333 Isolate::Current()->stub_cache()->GenerateProbe(
1333 masm, flags, rax, rcx, rbx, rdx); 1334 masm, flags, rax, rcx, rbx, rdx);
1334 1335
1335 // Cache miss: Jump to runtime. 1336 // Cache miss: Jump to runtime.
1336 StubCompiler::GenerateLoadMiss(masm, Code::LOAD_IC); 1337 StubCompiler::GenerateLoadMiss(masm, Code::LOAD_IC);
1337 } 1338 }
1338 1339
1339 1340
1340 void LoadIC::GenerateNormal(MacroAssembler* masm) { 1341 void LoadIC::GenerateNormal(MacroAssembler* masm) {
1341 // ----------- S t a t e ------------- 1342 // ----------- S t a t e -------------
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
1687 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1688 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1688 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1689 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1689 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1690 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1690 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1691 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1691 } 1692 }
1692 1693
1693 1694
1694 } } // namespace v8::internal 1695 } } // namespace v8::internal
1695 1696
1696 #endif // V8_TARGET_ARCH_X64 1697 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/stub-cache.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698