Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 12451003: Make IC patching resilient to flushing of the original target() ic. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1283 matching lines...) Expand 10 before | Expand all | Expand 10 after
1294 1294
1295 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) { 1295 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) {
1296 // ----------- S t a t e ------------- 1296 // ----------- S t a t e -------------
1297 // -- ecx : name 1297 // -- ecx : name
1298 // -- edx : receiver 1298 // -- edx : receiver
1299 // -- esp[0] : return address 1299 // -- esp[0] : return address
1300 // ----------------------------------- 1300 // -----------------------------------
1301 1301
1302 // Probe the stub cache. 1302 // Probe the stub cache.
1303 Code::Flags flags = Code::ComputeFlags( 1303 Code::Flags flags = Code::ComputeFlags(
1304 Code::LOAD_IC, MONOMORPHIC, Code::HANDLER_FRAGMENT); 1304 Code::STUB, MONOMORPHIC, Code::kNoExtraICState,
1305 Code::NORMAL, Code::LOAD_IC);
1305 Isolate::Current()->stub_cache()->GenerateProbe( 1306 Isolate::Current()->stub_cache()->GenerateProbe(
1306 masm, flags, edx, ecx, ebx, eax); 1307 masm, flags, edx, ecx, ebx, eax);
1307 1308
1308 // Cache miss: Jump to runtime. 1309 // Cache miss: Jump to runtime.
1309 GenerateMiss(masm); 1310 GenerateMiss(masm);
1310 } 1311 }
1311 1312
1312 1313
1313 void LoadIC::GenerateNormal(MacroAssembler* masm) { 1314 void LoadIC::GenerateNormal(MacroAssembler* masm) {
1314 // ----------- S t a t e ------------- 1315 // ----------- S t a t e -------------
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
1671 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1672 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1672 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1673 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1673 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1674 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1674 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1675 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1675 } 1676 }
1676 1677
1677 1678
1678 } } // namespace v8::internal 1679 } } // namespace v8::internal
1679 1680
1680 #endif // V8_TARGET_ARCH_IA32 1681 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698