Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1063)

Side by Side Diff: src/arm/ic-arm.cc

Issue 12451003: Make IC patching resilient to flushing of the original target() ic. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) { 655 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) {
656 // ----------- S t a t e ------------- 656 // ----------- S t a t e -------------
657 // -- r2 : name 657 // -- r2 : name
658 // -- lr : return address 658 // -- lr : return address
659 // -- r0 : receiver 659 // -- r0 : receiver
660 // -- sp[0] : receiver 660 // -- sp[0] : receiver
661 // ----------------------------------- 661 // -----------------------------------
662 662
663 // Probe the stub cache. 663 // Probe the stub cache.
664 Code::Flags flags = Code::ComputeFlags( 664 Code::Flags flags = Code::ComputeFlags(
665 Code::LOAD_IC, MONOMORPHIC, Code::HANDLER_FRAGMENT); 665 Code::STUB, MONOMORPHIC, Code::kNoExtraICState,
666 Code::NORMAL, Code::LOAD_IC);
666 Isolate::Current()->stub_cache()->GenerateProbe( 667 Isolate::Current()->stub_cache()->GenerateProbe(
667 masm, flags, r0, r2, r3, r4, r5, r6); 668 masm, flags, r0, r2, r3, r4, r5, r6);
668 669
669 // Cache miss: Jump to runtime. 670 // Cache miss: Jump to runtime.
670 GenerateMiss(masm); 671 GenerateMiss(masm);
671 } 672 }
672 673
673 674
674 void LoadIC::GenerateNormal(MacroAssembler* masm) { 675 void LoadIC::GenerateNormal(MacroAssembler* masm) {
675 // ----------- S t a t e ------------- 676 // ----------- S t a t e -------------
(...skipping 1005 matching lines...) Expand 10 before | Expand all | Expand 10 after
1681 } else { 1682 } else {
1682 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1683 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1683 patcher.EmitCondition(eq); 1684 patcher.EmitCondition(eq);
1684 } 1685 }
1685 } 1686 }
1686 1687
1687 1688
1688 } } // namespace v8::internal 1689 } } // namespace v8::internal
1689 1690
1690 #endif // V8_TARGET_ARCH_ARM 1691 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/stub-cache-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698