Issue 12447019: Eliminate CopyResultsFromGetResourceEntryCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12447019: Eliminate CopyResultsFromGetResourceEntryCallback. (Closed)

Created:
7 years, 9 months ago by hidehiko

Modified:
7 years, 9 months ago

Reviewers:
hashimoto, kinaba

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@b180569_create_copy_result_callback

Visibility:
Public.

More Reviews

Description

Eliminate CopyResultsFromGetResourceEntryCallback. Replace the method with CreateCopyResultCallback and CreateComposedCallback. BUG=180569 TEST=Ran ./out/Debug/unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188301

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -74 lines)			Patch
M	chrome/browser/chromeos/drive/drive_file_system_unittest.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_scheduler_unittest.cc	View	1	3 chunks	+3 lines, -12 lines	0 comments	Download
M	chrome/browser/google_apis/fake_drive_service_unittest.cc	View	1	14 chunks	+14 lines, -42 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/google_apis/test_util.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hidehiko

This CL is based on https://codereview.chromium.org/12785003/. Thank you for your review in advance, - hidehiko

7 years, 9 months ago (2013-03-13 05:46:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12447019/5001

7 years, 9 months ago (2013-03-15 02:37:12 UTC) #4

Message was sent while issue was closed.

Change committed as 188301

Expand Messages | Collapse Messages