Forward declare base::Time in uniformity trials.

Forward declare base::Time in uniformity trials.

Some fixes from a late code review for: https://codereview.chromium.org/12334124

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186253

[SteveT, 2013-03-05 16:22:40]

PTAL

[tfarina, 2013-03-05 16:46:24]

lgtm, thanks.

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
File chrome/common/metrics/variations/uniformity_field_trials.cc (right):

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
chrome/common/metrics/variations/uniformity_field_trials.cc:7: #include
"base/metrics/field_trial.h"
do you want to include base/time.h? now here?

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
chrome/common/metrics/variations/uniformity_field_trials.cc:72: void
SetupNewInstallUniformityTrial(const base::Time& install_date) {
do you want to pass by value here too?

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
File chrome/common/metrics/variations/uniformity_field_trials.h (right):

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
chrome/common/metrics/variations/uniformity_field_trials.h:1: // Copyright (c)
2013 The Chromium Authors. All rights reserved.
I know this might annoy people, but while you are here do you mind removing (c)?

[SteveT, 2013-03-05 17:54:23]

All done. Comitting.

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
File chrome/common/metrics/variations/uniformity_field_trials.cc (right):

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
chrome/common/metrics/variations/uniformity_field_trials.cc:7: #include
"base/metrics/field_trial.h"
On 2013/03/05 16:46:24, tfarina wrote:
> do you want to include base/time.h? now here?

Done.

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
chrome/common/metrics/variations/uniformity_field_trials.cc:72: void
SetupNewInstallUniformityTrial(const base::Time& install_date) {
On 2013/03/05 16:46:24, tfarina wrote:
> do you want to pass by value here too?

Done.

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
File chrome/common/metrics/variations/uniformity_field_trials.h (right):

https://codereview.chromium.org/12447006/diff/1/chrome/common/metrics/variati...
chrome/common/metrics/variations/uniformity_field_trials.h:1: // Copyright (c)
2013 The Chromium Authors. All rights reserved.
On 2013/03/05 16:46:24, tfarina wrote:
> I know this might annoy people, but while you are here do you mind removing
(c)?

Sure!

[commit-bot: I haz the power, 2013-03-05 17:54:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/12447006/8001

[commit-bot: I haz the power, 2013-03-05 20:50:35]

Change committed as 186253