Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 12446008: Add reviewers to optional outputs for changes (Closed)

Created:
7 years, 9 months ago by cjhopman
Modified:
7 years, 9 months ago
Reviewers:
cmp, enne (OOO)
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, nilesh
Visibility:
Public.

Description

Add reviewers to optional outputs for changes This adds a comma-separated list of reviewers to the optional outputs for changes. This can be added to the output using the custom formatter option. E.g. --output-format-changes="{url} {title} <{reviewers}>" Also, for webkit changes, use CommitterList to map reviewer names to emails so that they are similar format to other changes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=187351

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M my_activity.py View 1 5 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cjhopman
enne: check if the webkit change is reasonable cmp: OWNERS
7 years, 9 months ago (2013-03-11 18:12:21 UTC) #1
Agrawal
On 2013/03/11 18:12:21, cjhopman wrote: > enne: check if the webkit change is reasonable > ...
7 years, 9 months ago (2013-03-11 18:27:57 UTC) #2
Agrawal
On 2013/03/11 18:27:57, Agrawal wrote: > On 2013/03/11 18:12:21, cjhopman wrote: > > enne: check ...
7 years, 9 months ago (2013-03-11 18:28:26 UTC) #3
cmp
lgtm
7 years, 9 months ago (2013-03-11 18:37:53 UTC) #4
enne (OOO)
WebKit change lgtm (although there's only ever one WebKit reviewer for any patch). https://codereview.chromium.org/12446008/diff/1/my_activity.py File ...
7 years, 9 months ago (2013-03-11 19:14:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12446008/6003
7 years, 9 months ago (2013-03-11 19:59:44 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 20:02:45 UTC) #7
Message was sent while issue was closed.
Change committed as 187351

Powered by Google App Engine
This is Rietveld 408576698