Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 12442002: Details wrt parallel recompilation. (Closed)

Created:
7 years, 9 months ago by Yang
Modified:
7 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Details wrt parallel recompilation. This includes: - actually release handles kept by compilation info when compilation completes. - do not use parallel recompilation on single core CPUs. - artificially delay parallel recompilation for debugging. - fix outdated assertions wrt optimization status. - add "parallel" option to %OptimizeFunctionOnNextCall. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13827

Patch Set 1 #

Total comments: 2

Patch Set 2 : re-added accidental delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -44 lines) Patch
M src/compiler.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/isolate.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M src/optimizing-compiler-thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/optimizing-compiler-thread.cc View 4 chunks +45 lines, -14 lines 0 comments Download
M src/runtime.cc View 1 3 chunks +30 lines, -16 lines 0 comments Download
M src/smart-pointers.h View 1 chunk +3 lines, -2 lines 0 comments Download
A + test/mjsunit/parallel-optimize-disabled.js View 1 chunk +11 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
7 years, 9 months ago (2013-03-05 12:09:42 UTC) #1
Jakob Kummerow
https://chromiumcodereview.appspot.com/12442002/diff/1/src/runtime.cc File src/runtime.cc (left): https://chromiumcodereview.appspot.com/12442002/diff/1/src/runtime.cc#oldcode7713 src/runtime.cc:7713: function->shared()->code()->set_profiler_ticks(0); Where did this line go?
7 years, 9 months ago (2013-03-05 14:11:55 UTC) #2
Yang
https://codereview.chromium.org/12442002/diff/1/src/runtime.cc File src/runtime.cc (left): https://codereview.chromium.org/12442002/diff/1/src/runtime.cc#oldcode7713 src/runtime.cc:7713: function->shared()->code()->set_profiler_ticks(0); On 2013/03/05 14:11:55, Jakob wrote: > Where did ...
7 years, 9 months ago (2013-03-05 15:57:50 UTC) #3
Jakob Kummerow
LGTM. On 2013/03/05 15:57:50, Yang wrote: > Good point, accidentally deleted. Runtime_ParallelRecompile also needs this. ...
7 years, 9 months ago (2013-03-05 16:20:50 UTC) #4
Yang
7 years, 9 months ago (2013-03-05 16:22:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r13827 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698