pkg/intl/lib/bidi_formatter.dart - Issue 12441003: Rename String.concat to operator+.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/intl/lib/bidi_formatter.dart

Issue 12441003: Rename String.concat to operator+. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/intl/lib/bidi_formatter.dart

diff --git a/pkg/intl/lib/bidi_formatter.dart b/pkg/intl/lib/bidi_formatter.dart

index ae7b908e902af23d1106a66d441a2f11dd71eb7f..a9655f9497deeead6c9d5435f0e67db6e49a1d23 100644

--- a/pkg/intl/lib/bidi_formatter.dart

+++ b/pkg/intl/lib/bidi_formatter.dart

@@ -130,7 +130,7 @@ class BidiFormatter {

} else {

result = text;

}

- return result.concat(resetDir? _resetDir(text, direction, isHtml) : '');

+ return result + (resetDir? _resetDir(text, direction, isHtml) : '');

}

/**

@@ -161,7 +161,7 @@ class BidiFormatter {

result = "${marker}$text${Bidi.PDF}";

}

- return result.concat(resetDir? _resetDir(text, direction, isHtml) : '');

+ return result + (resetDir? _resetDir(text, direction, isHtml) : '');

}

/**

« no previous file with comments | « no previous file | pkg/intl/lib/src/date_format_field.dart » ('j') | no next file with comments »