Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: runtime/lib/invocation_mirror_patch.dart

Issue 12441003: Rename String.concat to operator+. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/intl/lib/src/date_format_field.dart ('k') | runtime/lib/string_base.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class _InvocationMirror implements InvocationMirror { 5 class _InvocationMirror implements InvocationMirror {
6 // Constants describing the invocation type. 6 // Constants describing the invocation type.
7 // _FIELD cannot be generated by regular invocation mirrors. 7 // _FIELD cannot be generated by regular invocation mirrors.
8 static const int _METHOD = 0; 8 static const int _METHOD = 0;
9 static const int _GETTER = 1; 9 static const int _GETTER = 1;
10 static const int _SETTER = 2; 10 static const int _SETTER = 2;
(...skipping 22 matching lines...) Expand all
33 int _type; 33 int _type;
34 List _positionalArguments; 34 List _positionalArguments;
35 Map<String, dynamic> _namedArguments; 35 Map<String, dynamic> _namedArguments;
36 36
37 void _setMemberNameAndType() { 37 void _setMemberNameAndType() {
38 if (_functionName.startsWith("get:")) { 38 if (_functionName.startsWith("get:")) {
39 _type = _GETTER; 39 _type = _GETTER;
40 _memberName = _functionName.substring(4); 40 _memberName = _functionName.substring(4);
41 } else if (_functionName.startsWith("set:")) { 41 } else if (_functionName.startsWith("set:")) {
42 _type = _SETTER; 42 _type = _SETTER;
43 _memberName = _functionName.substring(4).concat("="); 43 _memberName = _functionName.substring(4) + "=";
44 } else { 44 } else {
45 _type = _METHOD; 45 _type = _METHOD;
46 _memberName = _functionName; 46 _memberName = _functionName;
47 } 47 }
48 } 48 }
49 49
50 String get memberName { 50 String get memberName {
51 if (_memberName == null) { 51 if (_memberName == null) {
52 _setMemberNameAndType(); 52 _setMemberNameAndType();
53 } 53 }
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 String functionName, 120 String functionName,
121 List argumentsDescriptor, 121 List argumentsDescriptor,
122 List arguments) 122 List arguments)
123 native "InvocationMirror_invoke"; 123 native "InvocationMirror_invoke";
124 124
125 invokeOn(Object receiver) { 125 invokeOn(Object receiver) {
126 return _invoke(receiver, _functionName, _argumentsDescriptor, _arguments); 126 return _invoke(receiver, _functionName, _argumentsDescriptor, _arguments);
127 } 127 }
128 } 128 }
129 129
OLDNEW
« no previous file with comments | « pkg/intl/lib/src/date_format_field.dart ('k') | runtime/lib/string_base.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698