Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 12440058: Enforce 15 minutes timeout for all operations and 30 minutes for checkouts. (Closed)

Created:
7 years, 9 months ago by csharp
Modified:
7 years, 9 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Enforce 15 minutes timeout for all operations and 30 minutes for checkouts. svn commit likes to hang indefinitely whenever the svnserve server forgets about the client. This changes ensures the commit queue won't be blocked by this problem. R=maruel@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=189382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M checkout.py View 8 chunks +29 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
csharp
7 years, 9 months ago (2013-03-20 20:12:35 UTC) #1
M-A Ruel
lgtm
7 years, 9 months ago (2013-03-20 20:18:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/12440058/1
7 years, 9 months ago (2013-03-20 20:19:24 UTC) #3
iannucci
On 2013/03/20 20:12:35, csharp wrote: Would it make sense to monitor the command output and ...
7 years, 9 months ago (2013-03-20 20:20:21 UTC) #4
commit-bot: I haz the power
Change committed as 189382
7 years, 9 months ago (2013-03-20 20:21:37 UTC) #5
M-A Ruel
On 2013/03/20 20:20:21, iannucci wrote: > On 2013/03/20 20:12:35, csharp wrote: > > Would it ...
7 years, 9 months ago (2013-03-20 20:26:15 UTC) #6
iannucci
7 years, 9 months ago (2013-03-20 20:28:50 UTC) #7
Message was sent while issue was closed.
On 2013/03/20 20:26:15, Marc-Antoine Ruel wrote:
> On 2013/03/20 20:20:21, iannucci wrote:
> > On 2013/03/20 20:12:35, csharp wrote:
> > 
> > Would it make sense to monitor the command output and have a shorter
> > 'no_output_timeout'? That way the timeout isn't a guess at how long a given
> > source operation should take, but more of a guess of how long a single file
> > operation should take.
> > 
> > That would require a bit more surgery to implement though.
> 
> I'm doing code like that in run_test_cases. It's not available here though.

I guess hopefully the source operations don't take THAT long anyway...

Powered by Google App Engine
This is Rietveld 408576698