Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 12440036: Move ByteStream to content/browser (Closed)

Created:
7 years, 9 months ago by Zachary Kuznia
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, benjhayden+dwatch_chromium.org, jam, rdsmith+dwatch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move ByteStream to content/browser BUG=180833 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189665

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1160 lines) Patch
A + content/browser/byte_stream.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/byte_stream.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + content/browser/byte_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/download/byte_stream.h View 1 1 chunk +0 lines, -199 lines 0 comments Download
D content/browser/download/byte_stream.cc View 1 1 chunk +0 lines, -434 lines 0 comments Download
D content/browser/download/byte_stream_unittest.cc View 1 chunk +0 lines, -507 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_file_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_file_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/streams/stream.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/mock_download_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Zachary Kuznia
Hi Randy, Could you have a look at this? Thanks, -Zach
7 years, 9 months ago (2013-03-12 07:07:31 UTC) #1
Randy Smith (Not in Mondays)
LGTM. Thanks for fixing my silly ordering mistakes :-}.
7 years, 9 months ago (2013-03-12 14:58:33 UTC) #2
Zachary Kuznia
Hi Antoine, Could you do an OWNERS review of this? Thanks, -Zach
7 years, 9 months ago (2013-03-21 07:33:06 UTC) #3
piman
lgtm
7 years, 9 months ago (2013-03-21 16:17:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/12440036/14001
7 years, 9 months ago (2013-03-21 16:26:13 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-21 18:35:48 UTC) #6
Message was sent while issue was closed.
Change committed as 189665

Powered by Google App Engine
This is Rietveld 408576698