Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12438016: Save display preference when all display configuration changes has been completed. (Closed)

Created:
7 years, 9 months ago by oshima
Modified:
7 years, 9 months ago
Reviewers:
Jun Mukai, sky
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Save display preference when all display configuration changes has been completed. Add OnDisplayConfigurationChanged to DisplayController::Observer Save primary only in ExtededDesktop mode TBR=sky@chromium.org BUG=196818 TEST=covered by test, and also tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189040

Patch Set 1 : #

Patch Set 2 : bootstrap #

Total comments: 1

Patch Set 3 : fix style #

Patch Set 4 : replace dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -118 lines) Patch
M ash/display/display_controller.h View 4 chunks +8 lines, -0 lines 0 comments Download
M ash/display/display_controller.cc View 6 chunks +6 lines, -3 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 6 chunks +40 lines, -14 lines 0 comments Download
M ash/display/display_manager.cc View 1 2 5 chunks +22 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 3 chunks +4 lines, -4 lines 0 comments Download
A chrome/browser/chromeos/display/display_configuration_observer.h View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/display/display_configuration_observer.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences.cc View 1 2 3 2 chunks +8 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/display/primary_display_switch_observer.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/chromeos/display/primary_display_switch_observer.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
oshima
7 years, 9 months ago (2013-03-18 19:18:17 UTC) #1
Jun Mukai
lgtm https://codereview.chromium.org/12438016/diff/9001/ash/display/display_manager.cc File ash/display/display_manager.cc (right): https://codereview.chromium.org/12438016/diff/9001/ash/display/display_manager.cc#newcode182 ash/display/display_manager.cc:182: if (info.id() == display_id){ style nit: space between ...
7 years, 9 months ago (2013-03-19 01:20:44 UTC) #2
oshima
sky -> TBR for chrome/chrome_browser_chromeos.gypi
7 years, 9 months ago (2013-03-19 01:41:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12438016/13001
7 years, 9 months ago (2013-03-19 01:44:38 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-19 03:21:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12438016/13001
7 years, 9 months ago (2013-03-19 03:28:26 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=94633
7 years, 9 months ago (2013-03-19 05:28:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12438016/13001
7 years, 9 months ago (2013-03-19 06:31:48 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=94652
7 years, 9 months ago (2013-03-19 07:36:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12438016/13001
7 years, 9 months ago (2013-03-19 07:40:23 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=94667
7 years, 9 months ago (2013-03-19 08:24:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12438016/36001
7 years, 9 months ago (2013-03-19 13:01:52 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 16:40:21 UTC) #13
Message was sent while issue was closed. 
Change committed as 189040

Powered by Google App Engine
This is Rietveld 408576698