Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 12438013: Move InputMethod misc class from c/b/chromeos (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka
Modified:
7 years, 9 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Move InputMethod misc class from c/b/chromeos This is part of extraction work for input method from chrome/browser/chromeos. This CL extract InputMethodProperty, InputMethodConfig and IBus related key mapping function from chrome/browser/chromeos to chromeos/ime. BUG=164375 TEST=None TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190403

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -562 lines) Patch
M chrome/browser/chromeos/input_method/ibus_controller_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/ibus_keymap.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/chromeos/input_method/ibus_keymap.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_config.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_config.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_property.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_property.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_property_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_ibus_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
A + chromeos/ime/ibus_keymap.h View 1 chunk +7 lines, -6 lines 0 comments Download
A + chromeos/ime/ibus_keymap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chromeos/ime/input_method_config.h View 2 chunks +6 lines, -5 lines 0 comments Download
A + chromeos/ime/input_method_config.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chromeos/ime/input_method_property.h View 2 chunks +6 lines, -5 lines 0 comments Download
A + chromeos/ime/input_method_property.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chromeos/ime/input_method_property_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
7 years, 9 months ago (2013-03-19 02:12:00 UTC) #1
satorux1
LGTM
7 years, 9 months ago (2013-03-21 04:03:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12438013/10001
7 years, 9 months ago (2013-03-25 12:05:52 UTC) #3
commit-bot: I haz the power
Presubmit check for 12438013-10001 failed and returned exit status 1. INFO:root:Found 17 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-25 12:05:59 UTC) #4
Seigo Nonaka
TBR-ing for gypi file
7 years, 9 months ago (2013-03-25 12:10:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12438013/10001
7 years, 9 months ago (2013-03-25 12:11:01 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 15:32:13 UTC) #7
Message was sent while issue was closed.
Change committed as 190403

Powered by Google App Engine
This is Rietveld 408576698