Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 12438012: Extract input_method_whitelist.{h|cc} from c/b/chromeos. (Closed)

Created:
7 years, 9 months ago by Seigo Nonaka
Modified:
7 years, 9 months ago
Reviewers:
satorux1
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Extract input_method_whitelist.{h|cc} from c/b/chromeos. This is part of extraction work for input method from chrome/browser/chromeos. BUG=164375 TEST=None TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190596

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -517 lines) Patch
D chrome/browser/chromeos/input_method/gen_input_methods.py View 1 chunk +0 lines, -123 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/input_method.gyp View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/input_method_whitelist.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_whitelist.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_method_whitelist_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/chromeos/input_method/input_methods.txt View 1 chunk +0 lines, -212 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 chunks +1 line, -3 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 3 chunks +4 lines, -0 lines 0 comments Download
A + chromeos/ime/gen_input_methods.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chromeos/ime/input_method.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/ime/input_method_whitelist.h View 4 chunks +8 lines, -6 lines 0 comments Download
A + chromeos/ime/input_method_whitelist.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chromeos/ime/input_method_whitelist_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chromeos/ime/input_methods.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Seigo Nonaka
7 years, 9 months ago (2013-03-19 03:53:25 UTC) #1
satorux1
LGTM
7 years, 9 months ago (2013-03-21 04:05:48 UTC) #2
Seigo Nonaka
TBR-ing for gypi files.
7 years, 9 months ago (2013-03-25 15:42:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12438012/21001
7 years, 9 months ago (2013-03-25 15:42:50 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_browser_chromeos.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 9 months ago (2013-03-25 17:40:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12438012/35001
7 years, 9 months ago (2013-03-26 01:29:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/12438012/35001
7 years, 9 months ago (2013-03-26 06:50:33 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 08:36:15 UTC) #8
Message was sent while issue was closed.
Change committed as 190596

Powered by Google App Engine
This is Rietveld 408576698