Issue 12436010: Build app_list_unittests target for chromium_builder_tests on mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12436010: Build app_list_unittests target for chromium_builder_tests on mac. (Closed)

Created:
7 years, 9 months ago by tapted

Modified:
7 years, 9 months ago

Reviewers:
benwells

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Build app_list_unittests target for chromium_builder_tests on mac. The change in http://crrev.com/178260 only made the target visible on Windows. When the build target is chromium_builder_tests, OSX omits the target. BUG=138633 TEST=Target builds and runs when opted in with git cl try --clobber -bmac_rel:app_list_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187267

Patch Set 1 #

Patch Set 2 : looks like this is necessary #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	build/all.gyp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/12436010/3001

7 years, 9 months ago (2013-03-11 07:19:55 UTC) #3

Message was sent while issue was closed.

Change committed as 187267

Expand Messages | Collapse Messages