Issue 12432006: [telemetry] Fix Android surface statistics collector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12432006: [telemetry] Fix Android surface statistics collector (Closed)

Created:
7 years, 9 months ago by Sami

Modified:
7 years, 9 months ago

Reviewers:
bulach

CC:
chromium-reviews, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[telemetry] Fix Android surface statistics collector On Android we ask SurfaceFlinger about frame presentation times to estimate metrics such as frame rate and jitter. This data is recorded on a per-window basis. For applications that use SurfaceView, the statistics are reported separately for the main application window and the contained SurfaceView. Since we mainly care about the rendering performance of web content, we should track the statistics for the SurfaceView instead of the main Chrome window. BUG=http://b/8254709 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186801

Patch Set 1 #

Patch Set 2 : Fix a typo while we're at it. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -18 lines)			Patch
M	build/android/pylib/surface_stats_collector.py	View	1	3 chunks	+9 lines, -11 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/android_browser_finder.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/core/chrome/android_platform_backend.py	View		2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/12432006/2001

7 years, 9 months ago (2013-03-07 18:25:47 UTC) #3

Message was sent while issue was closed.

Change committed as 186801

Expand Messages | Collapse Messages