chrome/browser/ui/panels/display_settings_provider.cc - Issue 12430013: Fix panel showing logic when Chrome enters the fullscreen mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/display_settings_provider.cc

Issue 12430013: Fix panel showing logic when Chrome enters the fullscreen mode (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix per feedback Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/display_settings_provider.cc

diff --git a/chrome/browser/ui/panels/display_settings_provider.cc b/chrome/browser/ui/panels/display_settings_provider.cc

index a675aa89925975797d30864e0e16a1fde02c5d70..2312d44836d4617f941b43ccf2201965450bf04e 100644

--- a/chrome/browser/ui/panels/display_settings_provider.cc

+++ b/chrome/browser/ui/panels/display_settings_provider.cc

@@ -41,6 +41,7 @@ void DisplaySettingsProvider::RemoveDesktopBarObserver(

void DisplaySettingsProvider::AddFullScreenObserver(

FullScreenObserver* observer) {

+ is_full_screen_ = IsFullScreen();

full_screen_observers_.AddObserver(observer);

if (full_screen_observers_.size() == 1 && NeedsPeriodicFullScreenCheck()) {

@@ -137,7 +138,7 @@ void DisplaySettingsProvider::CheckFullScreenMode() {

OnFullScreenModeChanged(is_full_screen_));

}

-bool DisplaySettingsProvider::IsFullScreen() const {

+bool DisplaySettingsProvider::IsFullScreen() {

return IsFullScreenMode();

}