Fix panel showing logic when Chrome enters the fullscreen mode

When Chrome enters the fullscreen mode:
1) If the panel is created with initial focus, as in the case that the extension icon is clicked, the panel will be shown.
2) If the panel is created without initial focus, as in the case of new incoming message, the panel will not be shown.

When Chrome leaves the fullscreen mode, all panels that are delayed for showing will be shown now.

This patch also fixed the initial fullscreen detection problem for OSX. If Chrome enters fullscreen mode before any panel is created, we need to find out if chrome is in fullscreen or not.

BUG=180795
TEST=Manual test by creating panels when Chrome is in fullscreen mode


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188300

[Dmitry Titov, 2013-03-14 01:10:25]

https://codereview.chromium.org/12430013/diff/1/chrome/browser/ui/cocoa/panel...
File chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm (right):

https://codereview.chromium.org/12430013/diff/1/chrome/browser/ui/cocoa/panel...
chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm:21:
FULLSCREEN_UNKNOWN,
The naming suggestion: 
FULLSCREEN_ON
FULLSCREEN_OFF
FULLSCREEN_UNKNOWN

"entered" and "exited" indicate history - can it be 'exited' if it never was
there? sounds a bit confusing to me.

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/cocoa/pa...
File chrome/browser/ui/cocoa/panels/panel_cocoa.mm (right):

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/cocoa/pa...
chrome/browser/ui/cocoa/panels/panel_cocoa.mm:223: return;
why this return? don't we need to do the controller_ call?

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/cocoa/pa...
File chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm (right):

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/cocoa/pa...
chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm:854: if
(windowShim_->panel()->IsAlwaysOnTop()) {
early return?

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/panels/p...
File chrome/browser/ui/panels/panel.cc (right):

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/panels/p...
chrome/browser/ui/panels/panel.cc:269: // Only if the panel is created without
initial focus, we delay its showing
The description of the bug repeats this statement, but it's unclear why. Could
you update description to explain the rationale and maybe even add a comment
here to do the same?

[jianli, 2013-03-14 19:11:47]

https://codereview.chromium.org/12430013/diff/1/chrome/browser/ui/cocoa/panel...
File chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm (right):

https://codereview.chromium.org/12430013/diff/1/chrome/browser/ui/cocoa/panel...
chrome/browser/ui/cocoa/panels/display_settings_provider_cocoa.mm:21:
FULLSCREEN_UNKNOWN,
On 2013/03/14 01:10:25, Dmitry Titov wrote:
> The naming suggestion: 
> FULLSCREEN_ON
> FULLSCREEN_OFF
> FULLSCREEN_UNKNOWN
> 
> "entered" and "exited" indicate history - can it be 'exited' if it never was
> there? sounds a bit confusing to me.

Done.

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/cocoa/pa...
File chrome/browser/ui/cocoa/panels/panel_cocoa.mm (right):

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/cocoa/pa...
chrome/browser/ui/cocoa/panels/panel_cocoa.mm:223: return;
On 2013/03/14 01:10:25, Dmitry Titov wrote:
> why this return? don't we need to do the controller_ call?

No, we do not need the call. If the panel window has not been shown yet, we will
show it when |is_full_screen| is true and we do not need to show it and call the
controller when it is still in full screen mode. Added comment for this.

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/cocoa/pa...
File chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm (right):

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/cocoa/pa...
chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm:854: if
(windowShim_->panel()->IsAlwaysOnTop()) {
On 2013/03/14 01:10:25, Dmitry Titov wrote:
> early return?

Done.

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/panels/p...
File chrome/browser/ui/panels/panel.cc (right):

https://codereview.chromium.org/12430013/diff/4001/chrome/browser/ui/panels/p...
chrome/browser/ui/panels/panel.cc:269: // Only if the panel is created without
initial focus, we delay its showing
On 2013/03/14 01:10:25, Dmitry Titov wrote:
> The description of the bug repeats this statement, but it's unclear why. Could
> you update description to explain the rationale and maybe even add a comment
> here to do the same?

Removed this comment and put back the removed code in Panel::Show as discussed.

[Dmitry Titov, 2013-03-15 02:19:04]

lgtm

[commit-bot: I haz the power, 2013-03-15 04:53:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jianli@chromium.org/12430013/23001

[commit-bot: I haz the power, 2013-03-15 08:28:41]

Change committed as 188300