Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 12430010: Avoid sending nonempty view size with empty backing size. (Closed)

Created:
7 years, 9 months ago by aelias_OOO_until_Jul13
Modified:
7 years, 9 months ago
Reviewers:
no sievers
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, aruslan, jayjang, Jinsuk Kim (do not use this)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Avoid sending nonempty view size with empty backing size. This condition, which occurs during EmbedContentViewActivity initialization, results in a white-screen state because of the following sequence: 1. pending_resize_ack_ is set in RWHI. 2. didCompleteSwapBuffers is never called in RenderWidget because of the empty backing, therefore the resize ack is never sent. 3. When the backing size is set to a nonzero value, RWHI refuses to send it because it expects a pending resize. We can avoid this situation by returning 0 from GetViewBounds as well until the backing is initialized. BUG=181244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187347

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aelias_OOO_until_Jul13
PTAL, this solves the issue with settings-page usage of ContentView.
7 years, 9 months ago (2013-03-11 04:11:19 UTC) #1
no sievers
lgtm
7 years, 9 months ago (2013-03-11 17:31:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aelias@chromium.org/12430010/1
7 years, 9 months ago (2013-03-11 17:48:43 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-11 19:59:57 UTC) #4
Message was sent while issue was closed.
Change committed as 187347

Powered by Google App Engine
This is Rietveld 408576698