Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 12428002: Made gradient divider in GAIA signin screen. (Closed)

Created:
7 years, 9 months ago by dzhioev (left Google)
Modified:
7 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Made gradient divider in GAIA signin screen. BUG=153096 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186248

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 2 chunks +18 lines, -13 lines 2 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dzhioev (left Google)
7 years, 9 months ago (2013-03-05 08:48:10 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/12428002/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.css File chrome/browser/resources/chromeos/login/screen_gaia_signin.css (right): https://codereview.chromium.org/12428002/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.css#newcode48 chrome/browser/resources/chromeos/login/screen_gaia_signin.css:48: height: 100%; So seems that explicitly setting height=100% ...
7 years, 9 months ago (2013-03-05 14:05:53 UTC) #2
dzhioev (left Google)
https://codereview.chromium.org/12428002/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.css File chrome/browser/resources/chromeos/login/screen_gaia_signin.css (right): https://codereview.chromium.org/12428002/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.css#newcode48 chrome/browser/resources/chromeos/login/screen_gaia_signin.css:48: height: 100%; On 2013/03/05 14:05:53, Nikita Kostylev wrote: > ...
7 years, 9 months ago (2013-03-05 15:28:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/12428002/1
7 years, 9 months ago (2013-03-05 18:38:00 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 20:39:23 UTC) #5
Message was sent while issue was closed.
Change committed as 186248

Powered by Google App Engine
This is Rietveld 408576698