Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Issue 12426021: Reland "Add chromite and pyelftools to DEPS file." (Closed)

Created:
7 years, 9 months ago by rcui1
Modified:
7 years, 9 months ago
Reviewers:
cmp, szager, szager1
CC:
chromium-reviews
Visibility:
Public.

Description

Reland "Add chromite and pyelftools to DEPS file." Previous version was reverted because it broke check_license.py. Relanding now that the license issues are resolved. See crbug.com/222615. Used for the Simple Chrome Workflow (go/simple-chrome). pyelftools is a dependency of chromite. BUG=None TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M DEPS View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rcui1
inheriting lgtm from https://codereview.chromium.org/12212081/.
7 years, 9 months ago (2013-03-22 23:13:39 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 9 months ago (2013-03-22 23:22:07 UTC) #2
szager1
lgtm
7 years, 9 months ago (2013-03-22 23:24:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rcui@google.com/12426021/1
7 years, 9 months ago (2013-03-22 23:28:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rcui@google.com/12426021/1
7 years, 9 months ago (2013-03-23 14:47:10 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 17:26:56 UTC) #6
Message was sent while issue was closed.
Change committed as 190038

Powered by Google App Engine
This is Rietveld 408576698