Issue 12426015: create uniform string api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12426015: create uniform string api (Closed)

Created:
7 years, 9 months ago by dcarney

Modified:
7 years, 8 months ago

Reviewers:
Yang

CC:
svenpanne

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

create uniform string api R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14379

Patch Set 1 #

Total comments: 3

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -71 lines)			Patch
	M	include/v8.h	View		3 chunks	+62 lines, -5 lines	0 comments	Download
	M	src/api.cc	View		2 chunks	+107 lines, -66 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dcarney

cc'ing sven as it's an api change that might clash with the isolate parameter work

7 years, 9 months ago (2013-03-15 10:10:32 UTC) #1

Yang

LGTM with some comments. https://codereview.chromium.org/12426015/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/12426015/diff/1/src/api.cc#newcode5176 src/api.cc:5176: inline int StringLength(const char* string) ...

7 years, 9 months ago (2013-03-22 12:46:05 UTC) #2

Yang

7 years, 8 months ago (2013-04-22 15:20:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14379 (presubmit successful).

Expand Messages | Collapse Messages