Issue 12426008: Load/Store stub compilation refactoring.

Issue 12426008: Load/Store stub compilation refactoring. (Closed)

Created:
7 years, 9 months ago by Toon Verwaest

Modified:
7 years, 9 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Load/Store stub compilation refactoring. Committed: https://code.google.com/p/v8/source/detail?r=13954

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -396 lines)			Patch
M	src/arm/stub-cache-arm.cc	View		5 chunks	+31 lines, -130 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		7 chunks	+31 lines, -137 lines	0 comments	Download
M	src/stub-cache.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/stub-cache.cc	View	1	1 chunk	+65 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		6 chunks	+30 lines, -129 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://chromiumcodereview.appspot.com/12426008/diff/1/src/stub-cache.cc File src/stub-cache.cc (right): https://chromiumcodereview.appspot.com/12426008/diff/1/src/stub-cache.cc#newcode1627 src/stub-cache.cc:1627: GenerateRestoreName(masm(), &miss_restore_name, name); Restore removed new line before ...

7 years, 9 months ago (2013-03-15 08:28:21 UTC) #2

Toon Verwaest

Addressed comments https://chromiumcodereview.appspot.com/12426008/diff/1/src/stub-cache.cc File src/stub-cache.cc (right): https://chromiumcodereview.appspot.com/12426008/diff/1/src/stub-cache.cc#newcode1627 src/stub-cache.cc:1627: GenerateRestoreName(masm(), &miss_restore_name, name); On 2013/03/15 08:28:21, ulan ...

7 years, 9 months ago (2013-03-15 12:07:17 UTC) #3

Toon Verwaest

7 years, 9 months ago (2013-03-15 12:07:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r13954 (presubmit successful).

Expand Messages | Collapse Messages