Issue 12423007: Short term workaround to deal with calculation error caused by inverted matrix.

Issue 12423007: Short term workaround to deal with calculation error caused by inverted matrix. (Closed)

Created:
7 years, 9 months ago by oshima

Modified:
7 years, 9 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Short term workaround to deal with calculation error caused by inverted matrix. I'll work on better fix for m28 as described in the bug. BUG=222483 TEST=autohide launcher works on any side (lefr,right,top,bottom) when display is rotated. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190037

Patch Set 1 : #

Total comments: 1

Patch Set 2 : added test #

Patch Set 3 : keep inside only for mouse event #

Total comments: 2

Patch Set 4 : fix argument order #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -8 lines)			Patch
M	ui/aura/root_window.h	View	1 2 3	3 chunks	+8 lines, -2 lines	0 comments	Download
M	ui/aura/root_window.cc	View	1 2 3	4 chunks	+24 lines, -4 lines	0 comments	Download
M	ui/aura/root_window_unittest.cc	View	1 2 3	2 chunks	+42 lines, -0 lines	0 comments	Download
M	ui/aura/test/event_generator.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/events/event.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

oshima

https://codereview.chromium.org/12423007/diff/2001/ui/aura/root_window.cc File ui/aura/root_window.cc (right): https://codereview.chromium.org/12423007/diff/2001/ui/aura/root_window.cc#newcode674 ui/aura/root_window.cc:674: #if defined(OS_CHROMEOS) I put inside ifdef to avoid potential ...

7 years, 9 months ago (2013-03-20 20:52:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12423007/12005

7 years, 9 months ago (2013-03-21 00:02:17 UTC) #5

oshima

Turns out that gesture event can be outside of root window, so I changed again ...

7 years, 9 months ago (2013-03-21 01:23:16 UTC) #6

sky

SLGTM https://codereview.chromium.org/12423007/diff/25006/ui/aura/root_window.h File ui/aura/root_window.h (right): https://codereview.chromium.org/12423007/diff/25006/ui/aura/root_window.h#newcode317 ui/aura/root_window.h:317: void TransformEventForDeviceScaleFactor(ui::LocatedEvent* event, out params should be last, ...

7 years, 9 months ago (2013-03-21 14:44:12 UTC) #7

oshima

https://codereview.chromium.org/12423007/diff/25006/ui/aura/root_window.h File ui/aura/root_window.h (right): https://codereview.chromium.org/12423007/diff/25006/ui/aura/root_window.h#newcode317 ui/aura/root_window.h:317: void TransformEventForDeviceScaleFactor(ui::LocatedEvent* event, On 2013/03/21 14:44:12, sky wrote: > ...

7 years, 9 months ago (2013-03-21 15:41:47 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12423007/31001

7 years, 9 months ago (2013-03-21 15:41:58 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12423007/31001

7 years, 9 months ago (2013-03-22 18:15:00 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12423007/31001

7 years, 9 months ago (2013-03-23 14:46:41 UTC) #11

Message was sent while issue was closed.

Change committed as 190037

Expand Messages | Collapse Messages