Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12421007: Modify developer_private extensions api to use JSON Schema Compiler (Closed)

Created:
7 years, 9 months ago by Aaron Jacobs
Modified:
7 years, 9 months ago
Reviewers:
Devlin, cduvall, Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Modify developer_private extensions api to use JSON Schema Compiler BUG=121174 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190036

Patch Set 1 #

Total comments: 4

Patch Set 2 : cduvall #

Total comments: 6

Patch Set 3 : Removed AUTHORS file change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -36 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 8 chunks +49 lines, -36 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Aaron Jacobs
7 years, 9 months ago (2013-03-07 22:35:51 UTC) #1
cduvall
https://codereview.chromium.org/12421007/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12421007/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode687 chrome/browser/extensions/api/developer_private/developer_private_api.cc:687: base::FilePath::FromWStringHack(UTF8ToWide(item_path_str_)); four space indent from prev line https://codereview.chromium.org/12421007/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode690 chrome/browser/extensions/api/developer_private/developer_private_api.cc:690: ...
7 years, 9 months ago (2013-03-07 22:43:33 UTC) #2
Aaron Jacobs
https://codereview.chromium.org/12421007/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12421007/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode687 chrome/browser/extensions/api/developer_private/developer_private_api.cc:687: base::FilePath::FromWStringHack(UTF8ToWide(item_path_str_)); On 2013/03/07 22:43:33, cduvall wrote: > four space ...
7 years, 9 months ago (2013-03-07 22:45:48 UTC) #3
cduvall
https://codereview.chromium.org/12421007/diff/4001/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12421007/diff/4001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode77 chrome/browser/extensions/api/developer_private/developer_private_api.cc:77: namespace ChoosePath = api::developer_private::ChoosePath; not used https://codereview.chromium.org/12421007/diff/4001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode79 chrome/browser/extensions/api/developer_private/developer_private_api.cc:79: namespace ...
7 years, 9 months ago (2013-03-07 22:48:57 UTC) #4
Aaron Jacobs
https://codereview.chromium.org/12421007/diff/4001/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12421007/diff/4001/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode77 chrome/browser/extensions/api/developer_private/developer_private_api.cc:77: namespace ChoosePath = api::developer_private::ChoosePath; On 2013/03/07 22:48:57, cduvall wrote: ...
7 years, 9 months ago (2013-03-14 22:53:32 UTC) #5
cduvall
lgtm
7 years, 9 months ago (2013-03-22 00:35:58 UTC) #6
Aaron Jacobs
+mpcomplete please take a look
7 years, 9 months ago (2013-03-22 17:17:32 UTC) #7
Matt Perry
lgtm
7 years, 9 months ago (2013-03-22 17:44:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Samusaaron3@gmail.com/12421007/9001
7 years, 9 months ago (2013-03-22 20:34:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Samusaaron3@gmail.com/12421007/9001
7 years, 9 months ago (2013-03-23 14:46:28 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 17:26:08 UTC) #11
Message was sent while issue was closed. 
Change committed as 190036

Powered by Google App Engine
This is Rietveld 408576698