Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: runtime/vm/assembler_x64.h

Issue 1241863002: VM: Refactor allocation stats code and remove duplicate code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: make context allocation isolate-independent Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64.h
diff --git a/runtime/vm/assembler_x64.h b/runtime/vm/assembler_x64.h
index 56cff9caaca4b7e570873cb207f93d68c992393b..dcfaadd541648be863b03665ad9ef3f60ee86e78 100644
--- a/runtime/vm/assembler_x64.h
+++ b/runtime/vm/assembler_x64.h
@@ -984,15 +984,18 @@ class Assembler : public ValueObject {
return kEntryPointToPcMarkerOffset;
}
- void UpdateAllocationStats(intptr_t cid,
- Heap::Space space);
+ ClassHeapStats** UpdateAllocationStats(intptr_t cid,
+ Heap::Space space,
+ bool inline_isolate = true);
void UpdateAllocationStatsWithSize(intptr_t cid,
Register size_reg,
- Heap::Space space);
+ Heap::Space space,
+ bool inline_isolate = true);
void UpdateAllocationStatsWithSize(intptr_t cid,
intptr_t instance_size,
- Heap::Space space);
+ Heap::Space space,
+ bool inline_isolate = true);
// If allocation tracing for |cid| is enabled, will jump to |trace| label,
// which will allocate in the runtime where tracing occurs.
@@ -1135,8 +1138,6 @@ class Assembler : public ValueObject {
Heap::Space space,
Address* count_address,
Address* size_address);
- void ComputeHeapStatsStateAddressForCid(intptr_t cid,
- Address* state_address);
DISALLOW_ALLOCATION();
DISALLOW_COPY_AND_ASSIGN(Assembler);
};

Powered by Google App Engine
This is Rietveld 408576698