Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: runtime/vm/assembler_ia32.h

Issue 1241863002: VM: Refactor allocation stats code and remove duplicate code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_IA32_H_ 5 #ifndef VM_ASSEMBLER_IA32_H_
6 #define VM_ASSEMBLER_IA32_H_ 6 #define VM_ASSEMBLER_IA32_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_ia32.h directly; use assembler.h instead. 9 #error Do not include assembler_ia32.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 862 matching lines...) Expand 10 before | Expand all | Expand 10 after
873 873
874 // If allocation tracing for |cid| is enabled, will jump to |trace| label, 874 // If allocation tracing for |cid| is enabled, will jump to |trace| label,
875 // which will allocate in the runtime where tracing occurs. 875 // which will allocate in the runtime where tracing occurs.
876 void MaybeTraceAllocation(intptr_t cid, 876 void MaybeTraceAllocation(intptr_t cid,
877 Register temp_reg, 877 Register temp_reg,
878 Label* trace, 878 Label* trace,
879 bool near_jump); 879 bool near_jump);
880 880
881 void UpdateAllocationStats(intptr_t cid, 881 void UpdateAllocationStats(intptr_t cid,
882 Register temp_reg, 882 Register temp_reg,
883 Heap::Space space); 883 Heap::Space space,
884 bool inline_isolate = true);
884 885
885 void UpdateAllocationStatsWithSize(intptr_t cid, 886 void UpdateAllocationStatsWithSize(intptr_t cid,
886 Register size_reg, 887 Register size_reg,
887 Register temp_reg, 888 Register temp_reg,
888 Heap::Space space); 889 Heap::Space space,
890 bool inline_isolate = true);
889 void UpdateAllocationStatsWithSize(intptr_t cid, 891 void UpdateAllocationStatsWithSize(intptr_t cid,
890 intptr_t instance_size, 892 intptr_t instance_size,
891 Register temp_reg, 893 Register temp_reg,
892 Heap::Space space); 894 Heap::Space space,
895 bool inline_isolate = true);
893 896
894 // Inlined allocation of an instance of class 'cls', code has no runtime 897 // Inlined allocation of an instance of class 'cls', code has no runtime
895 // calls. Jump to 'failure' if the instance cannot be allocated here. 898 // calls. Jump to 'failure' if the instance cannot be allocated here.
896 // Allocated instance is returned in 'instance_reg'. 899 // Allocated instance is returned in 'instance_reg'.
897 // Only the tags field of the object is initialized. 900 // Only the tags field of the object is initialized.
898 void TryAllocate(const Class& cls, 901 void TryAllocate(const Class& cls,
899 Label* failure, 902 Label* failure,
900 bool near_jump, 903 bool near_jump,
901 Register instance_reg, 904 Register instance_reg,
902 Register temp_reg); 905 Register temp_reg);
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 } 1041 }
1039 1042
1040 1043
1041 inline void Assembler::EmitOperandSizeOverride() { 1044 inline void Assembler::EmitOperandSizeOverride() {
1042 EmitUint8(0x66); 1045 EmitUint8(0x66);
1043 } 1046 }
1044 1047
1045 } // namespace dart 1048 } // namespace dart
1046 1049
1047 #endif // VM_ASSEMBLER_IA32_H_ 1050 #endif // VM_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698