Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: runtime/vm/assembler_arm64.h

Issue 1241863002: VM: Refactor allocation stats code and remove duplicate code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_ARM64_H_ 5 #ifndef VM_ASSEMBLER_ARM64_H_
6 #define VM_ASSEMBLER_ARM64_H_ 6 #define VM_ASSEMBLER_ARM64_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_arm64.h directly; use assembler.h instead. 9 #error Do not include assembler_arm64.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 1362 matching lines...) Expand 10 before | Expand all | Expand 10 after
1373 void LeaveCallRuntimeFrame(); 1373 void LeaveCallRuntimeFrame();
1374 void CallRuntime(const RuntimeEntry& entry, intptr_t argument_count); 1374 void CallRuntime(const RuntimeEntry& entry, intptr_t argument_count);
1375 1375
1376 // Set up a stub frame so that the stack traversal code can easily identify 1376 // Set up a stub frame so that the stack traversal code can easily identify
1377 // a stub frame. 1377 // a stub frame.
1378 void EnterStubFrame(); 1378 void EnterStubFrame();
1379 void LeaveStubFrame(); 1379 void LeaveStubFrame();
1380 1380
1381 void UpdateAllocationStats(intptr_t cid, 1381 void UpdateAllocationStats(intptr_t cid,
1382 Register pp, 1382 Register pp,
1383 Heap::Space space); 1383 Heap::Space space,
1384 bool inline_isolate = true);
1384 1385
1385 void UpdateAllocationStatsWithSize(intptr_t cid, 1386 void UpdateAllocationStatsWithSize(intptr_t cid,
1386 Register size_reg, 1387 Register size_reg,
1387 Register pp, 1388 Register pp,
1388 Heap::Space space); 1389 Heap::Space space,
1390 bool inline_isolate = true);
1389 1391
1390 // If allocation tracing for |cid| is enabled, will jump to |trace| label, 1392 // If allocation tracing for |cid| is enabled, will jump to |trace| label,
1391 // which will allocate in the runtime where tracing occurs. 1393 // which will allocate in the runtime where tracing occurs.
1392 void MaybeTraceAllocation(intptr_t cid, 1394 void MaybeTraceAllocation(intptr_t cid,
1393 Register temp_reg, 1395 Register temp_reg,
1394 Register pp, 1396 Register pp,
1395 Label* trace); 1397 Label* trace);
1396 1398
1397 // Inlined allocation of an instance of class 'cls', code has no runtime 1399 // Inlined allocation of an instance of class 'cls', code has no runtime
1398 // calls. Jump to 'failure' if the instance cannot be allocated here. 1400 // calls. Jump to 'failure' if the instance cannot be allocated here.
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
1949 Register value, 1951 Register value,
1950 Label* no_update); 1952 Label* no_update);
1951 1953
1952 DISALLOW_ALLOCATION(); 1954 DISALLOW_ALLOCATION();
1953 DISALLOW_COPY_AND_ASSIGN(Assembler); 1955 DISALLOW_COPY_AND_ASSIGN(Assembler);
1954 }; 1956 };
1955 1957
1956 } // namespace dart 1958 } // namespace dart
1957 1959
1958 #endif // VM_ASSEMBLER_ARM64_H_ 1960 #endif // VM_ASSEMBLER_ARM64_H_
OLDNEW
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698