Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: runtime/vm/assembler_arm.h

Issue 1241863002: VM: Refactor allocation stats code and remove duplicate code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: addressed comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_ARM_H_ 5 #ifndef VM_ASSEMBLER_ARM_H_
6 #define VM_ASSEMBLER_ARM_H_ 6 #define VM_ASSEMBLER_ARM_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_arm.h directly; use assembler.h instead. 9 #error Do not include assembler_arm.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 892 matching lines...) Expand 10 before | Expand all | Expand 10 after
903 static intptr_t EntryPointToPcMarkerOffset() { 903 static intptr_t EntryPointToPcMarkerOffset() {
904 return TargetCPUFeatures::store_pc_read_offset(); 904 return TargetCPUFeatures::store_pc_read_offset();
905 } 905 }
906 906
907 // The register into which the allocation stats table is loaded with 907 // The register into which the allocation stats table is loaded with
908 // LoadAllocationStatsAddress should be passed to 908 // LoadAllocationStatsAddress should be passed to
909 // IncrementAllocationStats(WithSize) as stats_addr_reg to update the 909 // IncrementAllocationStats(WithSize) as stats_addr_reg to update the
910 // allocation stats. These are separate assembler macros so we can 910 // allocation stats. These are separate assembler macros so we can
911 // avoid a dependent load too nearby the load of the table address. 911 // avoid a dependent load too nearby the load of the table address.
912 void LoadAllocationStatsAddress(Register dest, 912 void LoadAllocationStatsAddress(Register dest,
913 intptr_t cid); 913 intptr_t cid,
914 bool inline_isolate = true);
914 void IncrementAllocationStats(Register stats_addr, 915 void IncrementAllocationStats(Register stats_addr,
915 intptr_t cid, 916 intptr_t cid,
916 Heap::Space space); 917 Heap::Space space);
917 void IncrementAllocationStatsWithSize(Register stats_addr_reg, 918 void IncrementAllocationStatsWithSize(Register stats_addr_reg,
918 Register size_reg, 919 Register size_reg,
919 intptr_t cid,
920 Heap::Space space); 920 Heap::Space space);
921 921
922 Address ElementAddressForIntIndex(bool is_load, 922 Address ElementAddressForIntIndex(bool is_load,
923 bool is_external, 923 bool is_external,
924 intptr_t cid, 924 intptr_t cid,
925 intptr_t index_scale, 925 intptr_t index_scale,
926 Register array, 926 Register array,
927 intptr_t index, 927 intptr_t index,
928 Register temp); 928 Register temp);
929 929
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
1140 Register new_value, 1140 Register new_value,
1141 FieldContent old_content); 1141 FieldContent old_content);
1142 1142
1143 DISALLOW_ALLOCATION(); 1143 DISALLOW_ALLOCATION();
1144 DISALLOW_COPY_AND_ASSIGN(Assembler); 1144 DISALLOW_COPY_AND_ASSIGN(Assembler);
1145 }; 1145 };
1146 1146
1147 } // namespace dart 1147 } // namespace dart
1148 1148
1149 #endif // VM_ASSEMBLER_ARM_H_ 1149 #endif // VM_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698