chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java - Issue 1241823002: Add UMA metrics for Bookmark widgets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java

Issue 1241823002: Add UMA metrics for Bookmark widgets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nico's nit Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java ('k') | chrome/browser/android/metrics/launch_metrics.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java

index 527097c1b1bae7acc7f3976d0a6b66ca437ec2f1..04c7b2e6c37edb3497be5b791dce7709c8c1798e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetProxy.java

@@ -9,6 +9,11 @@ import android.content.Context;

import android.content.Intent;

import android.util.Log;

+import org.chromium.chrome.browser.BookmarkUtils;

+import org.chromium.chrome.browser.ShortcutHelper;

+import org.chromium.chrome.browser.ShortcutSource;

+import org.chromium.chrome.browser.document.ChromeLauncherActivity;

/**

* Proxy that responds to tapping on the Bookmarks widget.

@@ -22,7 +27,9 @@ public class BookmarkWidgetProxy extends BroadcastReceiver {

BookmarkThumbnailWidgetService.changeFolder(context, intent);

} else {

Intent view = new Intent(intent);

- view.setComponent(null);

+ view.setClass(context, ChromeLauncherActivity.class);

+ view.putExtra(ShortcutHelper.EXTRA_SOURCE, ShortcutSource.BOOKMARK_NAVIGATOR_WIDGET);

+ view.putExtra(BookmarkUtils.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true);

startActivity(context, view);

}