chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java - Issue 1241823002: Add UMA metrics for Bookmark widgets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java

Issue 1241823002: Add UMA metrics for Bookmark widgets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/BUILD.gn ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkThumbnailWidgetService.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java

index ef8c8af6044af264fe286424cd06ebdf8447edae..85ccd6a2ba38e4d5075d8f4e3ab7638893d71755 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java

@@ -9,8 +9,11 @@ import android.graphics.Bitmap;

import android.graphics.Color;

import android.view.ViewGroup;

+import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.BookmarkUtils;

+import org.chromium.chrome.browser.ShortcutHelper;

+import org.chromium.chrome.browser.Source;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.favicon.FaviconHelper;

import org.chromium.chrome.browser.init.AsyncInitializationActivity;

@@ -73,7 +76,9 @@ public class ShortcutActivity extends AsyncInitializationActivity implements

Bitmap launcherIcon = BookmarkUtils.createLauncherIcon(this, favicon, url,

Color.red(dominantColor), Color.green(dominantColor), Color.blue(dominantColor));

Intent intent = BookmarkUtils.createAddToHomeIntent(url, title, launcherIcon);

+ intent.putExtra(ShortcutHelper.EXTRA_SOURCE, Source.BOOKMARK_SHORTCUT_WIDGET);

setResult(RESULT_OK, intent);

+ RecordUserAction.record("BookmarkShortcutWidgetAdded");

finish();

}