Do not push properties that are animated on impl only.

Do not push properties that are animated on impl only.

We currently avoid pushing properties when the main thread layer indicates that
it is animating. This code was incorrectly left behind after we started
animating on the main thread. Recently, we've added support for impl-only
animations. We should never push during one of these animations.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187875

[danakj, 2013-03-13 02:02:06]

+wjmaclean

So, if a layer is considered animating on both threads, then we should push the
value? Why is that?

https://codereview.chromium.org/12413020/diff/2001/cc/layer_impl.cc
File cc/layer_impl.cc (right):

https://codereview.chromium.org/12413020/diff/2001/cc/layer_impl.cc#newcode747
cc/layer_impl.cc:747: Animation* opacityAnimation =
m_layerAnimationController->getAnimation(Animation::Opacity);
You're going to need to rebase and chromify this CL.

[Ian Vollick, 2013-03-13 02:41:02]

We should push when we're animating or both threads because the new value is
fresher. IIRC the point of the old check had been to protect animated values
when we weren't animating on the main thread.

https://codereview.chromium.org/12413020/diff/2001/cc/layer_impl.cc
File cc/layer_impl.cc (right):

https://codereview.chromium.org/12413020/diff/2001/cc/layer_impl.cc#newcode747
cc/layer_impl.cc:747: Animation* opacityAnimation =
m_layerAnimationController->getAnimation(Animation::Opacity);
On 2013/03/13 02:02:06, danakj wrote:
> You're going to need to rebase and chromify this CL.

Done.

[enne (OOO), 2013-03-13 02:44:51]

lgtm

[commit-bot: I haz the power, 2013-03-13 13:43:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/12413020/7001

[commit-bot: I haz the power, 2013-03-13 16:35:19]

Change committed as 187875