Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3629)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/res/layout/autofill_dialog_content.xml

Issue 12412003: Initial UI structure for autofill dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Styling fixes Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/res/layout/autofill_address_spinner_dropdown.xml ('K') | « chrome/android/java/res/layout/autofill_cc_spinner_dropdown.xml ('k') | chrome/android/java/res/layout/autofill_dialog_title.xml » ('j') | chrome/android/java/res/layout/autofill_dialog_title.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/autofill_dialog_content.xml
diff --git a/chrome/android/java/res/layout/autofill_dialog_content.xml b/chrome/android/java/res/layout/autofill_dialog_content.xml
new file mode 100644
index 0000000000000000000000000000000000000000..e8320801f11e1256043691307a3ae7aff9345cd5
--- /dev/null
+++ b/chrome/android/java/res/layout/autofill_dialog_content.xml
@@ -0,0 +1,192 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+<?xml version="1.0" encoding="utf-8"?>
+<org.chromium.chrome.browser.autofill.AutofillDialogContentView xmlns:android="http://schemas.android.com/apk/res/android"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content">
+ <GridLayout
+ android:id="@+id/general_layout"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:columnCount="4">
+ <TextView
Ted C 2013/03/06 01:41:56 All of the children of this gridlayout should be i
Yusuf 2013/03/06 19:50:00 Done.
+ android:text="@string/autofill_billing_title"
+ android:id="@+id/billing_title"
+ android:layout_marginLeft="5dp"
+ android:layout_columnSpan="2"
+ android:textSize="14sp"/>
+ <Space
+ android:layout_gravity="fill"
+ android:layout_columnSpan="2"/>
+ <Spinner
+ android:layout_margin="5dp"
+ android:id="@+id/cc_spinner"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <TextView
+ android:text="@string/autofill_shipping_title"
+ android:id="@+id/shipping_title"
+ android:layout_marginLeft="5dp"
+ android:layout_columnSpan="2"
+ android:textSize="14sp"/>
+ <Space
+ android:layout_gravity="fill"
+ android:layout_columnSpan="2"/>
+ <Spinner
+ android:layout_margin="5dp"
+ android:id="@+id/address_spinner"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <CheckBox
+ android:id="@+id/check_box"
+ android:layout_margin="5dp"
+ android:textSize="12sp"
+ android:text="@string/autofill_use_wallet"
+ android:layout_columnSpan="4"/>
+ <View
+ android:id="@+id/line_bottom"
+ android:layout_height="1dp"
+ android:layout_columnSpan="4"
+ android:background="#D9D9DC"/>
+ <Button
+ android:text="By clicking the below button, you agree to the terms of service. And also some other text that makes sure this is not one line"
Ted C 2013/03/06 01:41:56 add this to strings.xml
+ android:padding="10dp"
+ android:id="@+id/terms_info"
+ android:textSize="11sp"
+ android:background="?android:attr/selectableItemBackground"
+ android:drawableRight="@drawable/arrow"
+ android:layout_columnSpan="4"
+ android:gravity="left"/>
+ </GridLayout>
+ <GridLayout
+ android:id="@+id/editing_layout_billing"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:columnCount="4">
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/card_number"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="Card Number"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
Ted C 2013/03/06 01:41:56 You'll also want to see how this behaves in access
Yusuf 2013/03/06 19:50:00 Adding this as a TODO. On 2013/03/06 01:41:56, Te
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/expiration_month"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="MM"/>
Ted C 2013/03/06 01:41:56 these should probably be in strings.xml as well a
Yusuf 2013/03/06 19:50:00 They are going to come from native. Removing them,
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/expiration_year"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="YY"/>
+ <Space
+ android:layout_columnSpan="1"
+ android:layout_gravity="fill"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/cvc_code"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="CVC"
+ android:layout_gravity="right"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/cardholder_name"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="Cardholder Name"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/billing_street_address_1"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="Street address"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/billing_street_address_2"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="Street address"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/billing_city"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="City"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/billing_zip_code"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="ZIP Code"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/billing_phone_number"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="Phone number"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ </GridLayout>
+ <GridLayout
Ted C 2013/03/06 01:41:56 I would pull these three grid layouts into separat
Yusuf 2013/03/06 19:50:00 Done.
+ android:id="@+id/editing_layout_shipping"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:columnCount="4">
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/recipient_name"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="Recipient name"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/street_address_1"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="Street address"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/street_address_2"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="Street address"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/city"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="City"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+ <EditText
+ android:layout_height="48dp"
+ android:id="@+id/zip_code"
+ android:layout_margin="2dp"
+ android:textSize="18sp"
+ android:hint="ZIP Code"
+ android:layout_gravity="fill_horizontal"
+ android:layout_columnSpan="4"/>
+</GridLayout>
Ted C 2013/03/06 01:41:56 indent messed up.
Yusuf 2013/03/06 19:50:00 Done.
Yusuf 2013/03/06 19:50:00 Done.
+ </org.chromium.chrome.browser.autofill.AutofillDialogContentView>
« chrome/android/java/res/layout/autofill_address_spinner_dropdown.xml ('K') | « chrome/android/java/res/layout/autofill_cc_spinner_dropdown.xml ('k') | chrome/android/java/res/layout/autofill_dialog_title.xml » ('j') | chrome/android/java/res/layout/autofill_dialog_title.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698