Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 12408035: Take advantage of XDAMAGE to support Screen Capture under ChromeOS. (Closed)

Created:
7 years, 9 months ago by Wez
Modified:
7 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Take advantage of XDAMAGE to support Screen Capture under ChromeOS. Screen Capture polls under Linux/X11, to avoid issues with poor XDAMAGE support in some X hardware drivers for things like 3D rendering. This CL enables XDAMAGE support under ChromeOS, since on that platform we can make sure that the drivers support it properly. BUG=177977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190032

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M media/video/capture/screen/screen_capture_device.cc View 1 chunk +7 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
Wez
PTAL
7 years, 9 months ago (2013-03-17 01:56:37 UTC) #1
Sergey Ulanov
lgtm https://chromiumcodereview.appspot.com/12408035/diff/1/media/video/capture/screen/screen_capture_device.cc File media/video/capture/screen/screen_capture_device.cc (right): https://chromiumcodereview.appspot.com/12408035/diff/1/media/video/capture/screen/screen_capture_device.cc#newcode277 media/video/capture/screen/screen_capture_device.cc:277: if (!screen_capturer_) nit: Maybe pull this line out ...
7 years, 9 months ago (2013-03-17 05:36:32 UTC) #2
Wez
https://chromiumcodereview.appspot.com/12408035/diff/1/media/video/capture/screen/screen_capture_device.cc File media/video/capture/screen/screen_capture_device.cc (right): https://chromiumcodereview.appspot.com/12408035/diff/1/media/video/capture/screen/screen_capture_device.cc#newcode277 media/video/capture/screen/screen_capture_device.cc:277: if (!screen_capturer_) On 2013/03/17 05:36:32, sergeyu wrote: > nit: ...
7 years, 9 months ago (2013-03-19 18:25:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12408035/1
7 years, 9 months ago (2013-03-21 20:26:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12408035/1
7 years, 9 months ago (2013-03-22 18:14:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12408035/1
7 years, 9 months ago (2013-03-22 20:07:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/12408035/1
7 years, 9 months ago (2013-03-23 14:46:19 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 16:39:49 UTC) #8
Message was sent while issue was closed.
Change committed as 190032

Powered by Google App Engine
This is Rietveld 408576698