Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 12408008: Reenable test ExtensionApiTest.UpdateWindowShowState for Windows (Closed)

Created:
7 years, 9 months ago by jianli
Modified:
7 years, 9 months ago
Reviewers:
miket_OOO, Dmitry Titov
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Reenable test ExtensionApiTest.UpdateWindowShowState for Windows This test was disabled some time ago. I did not find the suspicious patch in the range that could cause the failure. I enabled it and ran it locally and on trybot and it does not fail. BUG=176683 TEST=this is a test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188253

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix per feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/extensions/extension_tabs_apitest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jianli
7 years, 9 months ago (2013-03-12 00:12:01 UTC) #1
Dmitry Titov
please add more info - why it was disabled, what changed (if anything), what makes ...
7 years, 9 months ago (2013-03-13 21:59:19 UTC) #2
Dmitry Titov
One more: https://codereview.chromium.org/12408008/diff/1/chrome/browser/extensions/extension_tabs_apitest.cc File chrome/browser/extensions/extension_tabs_apitest.cc (left): https://codereview.chromium.org/12408008/diff/1/chrome/browser/extensions/extension_tabs_apitest.cc#oldcode43 chrome/browser/extensions/extension_tabs_apitest.cc:43: #endif // defined(USE_AURA) || defined(OS_MACOSX) || defined(OS_WIN) ...
7 years, 9 months ago (2013-03-13 22:01:09 UTC) #3
jianli
Updated the description. https://codereview.chromium.org/12408008/diff/1/chrome/browser/extensions/extension_tabs_apitest.cc File chrome/browser/extensions/extension_tabs_apitest.cc (left): https://codereview.chromium.org/12408008/diff/1/chrome/browser/extensions/extension_tabs_apitest.cc#oldcode43 chrome/browser/extensions/extension_tabs_apitest.cc:43: #endif // defined(USE_AURA) || defined(OS_MACOSX) || ...
7 years, 9 months ago (2013-03-13 22:07:24 UTC) #4
jianli
Mike, can you approve the patch as the owner? Thanks.
7 years, 9 months ago (2013-03-13 22:18:36 UTC) #5
miket_OOO
lgtm
7 years, 9 months ago (2013-03-14 21:07:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/12408008/6001
7 years, 9 months ago (2013-03-14 21:57:23 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-15 04:34:52 UTC) #8
Message was sent while issue was closed.
Change committed as 188253

Powered by Google App Engine
This is Rietveld 408576698