Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 12406012: Fix for short flings (scroll snapping used wrong axes) (Closed)

Created:
7 years, 9 months ago by aruslan
Modified:
7 years, 9 months ago
Reviewers:
Ted C, Yusuf, Yaron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix for short flings (scroll snapping used wrong axes) BUG=180205 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
aruslan
Please help with the review.
7 years, 9 months ago (2013-03-05 19:59:43 UTC) #1
Yusuf
lgtm. Thanks a lot for catching this Ruslan. I really appreciate it.
7 years, 9 months ago (2013-03-05 20:03:23 UTC) #2
Yaron
lgtm
7 years, 9 months ago (2013-03-05 20:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/12406012/1
7 years, 9 months ago (2013-03-05 20:30:55 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-05 20:42:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aruslan@chromium.org/12406012/1
7 years, 9 months ago (2013-03-05 20:44:04 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 20:50:22 UTC) #7
Message was sent while issue was closed.
Change committed as 186252

Powered by Google App Engine
This is Rietveld 408576698