Start isolate outdir in build directory

When running isolate command through the build tools, have the relative out directories get the same root, so that they all refer to the same location.

BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187305

[csharp, 2013-03-04 22:21:48]

Not sure if you'll agree with this patch or not.

The problem (as I see it) is that if you set test_isolation_outdir to
hashtable_dir/, and run chromium_swarm_tests, you end up with multiple hash
directories (one in base/, one in chrome/, and one in net/), since each one is
run with a different cwd.

This change will make it so all relative outdir paths set to
test_isolation_outdir are rooted to the output directory, so they are all
together (and easy to find).

[csharp, 2013-03-07 20:56:21]

ping for thoughts

[M-A Ruel, 2013-03-07 22:09:24]

Good idea, lgtm

[commit-bot: I haz the power, 2013-03-08 15:11:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/12398025/1002

[commit-bot: I haz the power, 2013-03-08 15:11:27]

Failed to apply patch for build/isolate.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/isolate.gypi
  Hunk #1 FAILED at 60.
  1 out of 1 hunk FAILED -- saving rejects to file build/isolate.gypi.rej

Patch:       build/isolate.gypi
Index: build/isolate.gypi
diff --git a/build/isolate.gypi b/build/isolate.gypi
index
4d291fcf87d73925ea7143b7bc8708ab0ee5f6ef..6ddc3fef2bfd1a3748f1103fff2c9fe18d9e609d
100644
--- a/build/isolate.gypi
+++ b/build/isolate.gypi
@@ -60,13 +60,20 @@
         'python',
         '<(DEPTH)/tools/swarm_client/isolate.py',
         '<(test_isolation_mode)',
-        '--outdir', '<(test_isolation_outdir)',
         '--variable', 'PRODUCT_DIR', '<(PRODUCT_DIR)',
         '--variable', 'OS', '<(OS)',
         '--variable', 'chromeos', '<(chromeos)',
         '--result', '<@(_outputs)',
         '--isolate', '<(RULE_INPUT_PATH)',
       ],
+      'conditions': [
+        ["test_isolation_outdir!=''", {
+          'action': [
+            '--outdir', '<(PRODUCT_DIR)/<(test_isolation_outdir)',
+          ],
+        }],
+      ],
+
       'msvs_cygwin_shell': 0,
     },
   ],

[commit-bot: I haz the power, 2013-03-08 15:19:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/12398025/7001

[commit-bot: I haz the power, 2013-03-08 15:22:42]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-03-08 20:06:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/12398025/7001

[commit-bot: I haz the power, 2013-03-09 14:44:13]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-03-11 13:05:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/12398025/7001

[commit-bot: I haz the power, 2013-03-11 16:32:28]

Change committed as 187305