Do not try to make Chrome default when registering it if it can't be made default unattended.

Do not try to make Chrome default when registering it if it can't be made default unattended.

We already have dialogs to take the user through the "make Chrome default" flow on platforms that require user actions to make Chrome default; we shouldn't try to honor the "make default" prefs in the middle of an install.

This CL reverts parts of http://crrev.com/142727.

BUG=172088
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186261

[gab, 2013-03-04 21:30:55]

Sir, please take a look.

Thanks,
Gab

[grt (UTC plus 2), 2013-03-05 03:27:10]

lgtm w/ changes below.

i wonder if we could somehow trigger the "You're almost done" dialog for the
next launch following an over-install where Chrome isn't the default browser.
what do you think?

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/instal...
File chrome/installer/setup/install.cc (right):

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/instal...
chrome/installer/setup/install.cc:10: #include <winuser.h>
remove this

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/instal...
chrome/installer/setup/install.cc:151: // Returns true if the current process is
running on the interactive window
remove this function and mention in the CL description that this change reverts
portions of r142727.

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/install.h
File chrome/installer/setup/install.h (right):

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/instal...
chrome/installer/setup/install.h:83: // If |make_chrome_default|, also attempts
to make Chrome default.
is this shorter form correct?
// If |make_chrome_default|, also attempts to make Chrome default where doing so
// requires no more user interaction than a UAC prompt. In practice, this means
// on versions of Windows prior to Windows 8.

[gab, 2013-03-05 16:29:32]

Thanks!

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/instal...
File chrome/installer/setup/install.cc (right):

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/instal...
chrome/installer/setup/install.cc:10: #include <winuser.h>
On 2013/03/05 03:27:10, grt wrote:
> remove this

Done.

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/install.h
File chrome/installer/setup/install.h (right):

https://codereview.chromium.org/12398024/diff/1/chrome/installer/setup/instal...
chrome/installer/setup/install.h:83: // If |make_chrome_default|, also attempts
to make Chrome default.
On 2013/03/05 03:27:10, grt wrote:
> is this shorter form correct?
> // If |make_chrome_default|, also attempts to make Chrome default where doing
so
> // requires no more user interaction than a UAC prompt. In practice, this
means
> // on versions of Windows prior to Windows 8.

Much better :)!

[gab, 2013-03-05 16:36:16]

On 2013/03/05 03:27:10, grt wrote:
> lgtm w/ changes below.
> 
> i wonder if we could somehow trigger the "You're almost done" dialog for the
> next launch following an over-install where Chrome isn't the default browser.
> what do you think?

As discussed with jeffreyc on some old bug, what we really want is to re-trigger
the first run experience on repair installs.

However I don't think we can do do this at the moment as first run forces an
overwrite of a user's preferences by the master_preferences (ideally only the
necessary prefs would be mapped from master_preferences, not a brainless
overwrite).

For now users will still get the infobar to make Chrome default, if it isn't
already, on repair installs.

Cheers,
Gab

[commit-bot: I haz the power, 2013-03-05 16:41:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/12398024/9001

[commit-bot: I haz the power, 2013-03-05 21:20:11]

Change committed as 186261