Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 12398012: Disable the aggressive memcmp checks under ASan. (Closed)

Created:
7 years, 9 months ago by Alexander Potapenko
Modified:
7 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, xusydoc+watch_chromium.org, cmp-cc_chromium.org, ilevy+cc_chromium.org, kjellander+cc_chromium.org
Visibility:
Public.

Description

Disable the aggressive memcmp checks under ASan. There currently are several bugs that prevent Chrome from starting up. BUG=178677, 178404 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=185923

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M scripts/slave/runtest.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Alexander Potapenko
PTAL
7 years, 9 months ago (2013-03-04 16:20:13 UTC) #1
Alexander Potapenko
On 2013/03/04 16:20:13, Alexander Potapenko wrote: > PTAL Another way to pass additional options to ...
7 years, 9 months ago (2013-03-04 16:30:52 UTC) #2
Alexander Potapenko
On 2013/03/04 16:20:13, Alexander Potapenko wrote: > PTAL Another way to pass additional options to ...
7 years, 9 months ago (2013-03-04 16:31:32 UTC) #3
Nico
lgtm
7 years, 9 months ago (2013-03-04 17:02:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/glider@chromium.org/12398012/1
7 years, 9 months ago (2013-03-04 17:55:07 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-04 17:59:23 UTC) #6
Message was sent while issue was closed.
Change committed as 185923

Powered by Google App Engine
This is Rietveld 408576698