ui/touch_selection/selection_event_type.h - Issue 1239583003: Update touch selection notification names, add ESTABLISHED.

Unified Diff: ui/touch_selection/selection_event_type.h

Issue 1239583003: Update touch selection notification names, add ESTABLISHED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add new SelectionEventTypes for bounds changing instead of reusing an insertion event. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java ('k') | ui/touch_selection/touch_selection_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/touch_selection/selection_event_type.h

diff --git a/ui/touch_selection/selection_event_type.h b/ui/touch_selection/selection_event_type.h

index 9de63f902fc2b31c5eed87a605acd36bb51960dc..be6173d55f71d5b5749e5e49989714c9ca1cf476 100644

--- a/ui/touch_selection/selection_event_type.h

+++ b/ui/touch_selection/selection_event_type.h

@@ -24,6 +24,8 @@ enum SelectionEventType {

INSERTION_CLEARED,

INSERTION_DRAG_STARTED,

INSERTION_DRAG_STOPPED,

+ BOUNDS_ESTABLISHED,

jdduke (slow) 2015/07/15 23:08:51 mohsen@: Any preference on naming here? We'd like

jdduke (slow) 2015/07/15 23:13:38 Hmm, or we could change the existing types, adding

mohsen 2015/07/16 18:02:49 The only issue I have with this suggestion is use

+ BOUNDS_DISSOLVED

};

} // namespace ui