Write a NativeThemeGtk2 class for linux_aura.

Write a NativeThemeGtk2 class for linux_aura.

This class vends GTK colors into views. There are a lot of little places where
cleanup is needed due to hard coded colors in views, but this is a start and
HighContrastInverse doesn't look too terrible.

BUG=130810
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186244

[sky, 2013-03-05 03:59:03]

LGTM

https://codereview.chromium.org/12395034/diff/2001/chrome/browser/ui/libgtk2u...
File chrome/browser/ui/libgtk2ui/native_theme_gtk2.h (right):

https://codereview.chromium.org/12395034/diff/2001/chrome/browser/ui/libgtk2u...
chrome/browser/ui/libgtk2ui/native_theme_gtk2.h:47: mutable GtkWidget*
fake_window_;
How come this one can't be an OwnedWidgetGtk too?

[Elliot Glaysher, 2013-03-05 17:31:52]

On 2013/03/05 03:59:03, sky wrote:
> LGTM
> 
>
https://codereview.chromium.org/12395034/diff/2001/chrome/browser/ui/libgtk2u...
> File chrome/browser/ui/libgtk2ui/native_theme_gtk2.h (right):
> 
>
https://codereview.chromium.org/12395034/diff/2001/chrome/browser/ui/libgtk2u...
> chrome/browser/ui/libgtk2ui/native_theme_gtk2.h:47: mutable GtkWidget*
> fake_window_;
> How come this one can't be an OwnedWidgetGtk too?

Because GtkWindows own themselves; the object is considered to own its refcount.

[commit-bot: I haz the power, 2013-03-05 17:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/12395034/2001

[sky, 2013-03-05 17:32:37]

Ah, ok. Thanks for clarifying.

On Tue, Mar 5, 2013 at 9:31 AM,  <erg@chromium.org> wrote:
> On 2013/03/05 03:59:03, sky wrote:
>>
>> LGTM
>
>
>
>
https://codereview.chromium.org/12395034/diff/2001/chrome/browser/ui/libgtk2u...
>>
>> File chrome/browser/ui/libgtk2ui/native_theme_gtk2.h (right):
>
>
>
>
https://codereview.chromium.org/12395034/diff/2001/chrome/browser/ui/libgtk2u...
>>
>> chrome/browser/ui/libgtk2ui/native_theme_gtk2.h:47: mutable GtkWidget*
>> fake_window_;
>> How come this one can't be an OwnedWidgetGtk too?
>
>
> Because GtkWindows own themselves; the object is considered to own its
> refcount.
>
> https://codereview.chromium.org/12395034/

[commit-bot: I haz the power, 2013-03-05 20:27:19]

Change committed as 186244

[Evan Stade, 2013-05-01 23:18:50]

https://chromiumcodereview.appspot.com/12395034/diff/2001/ui/views/controls/c...
File ui/views/controls/combobox/native_combobox_views.cc (right):

https://chromiumcodereview.appspot.com/12395034/diff/2001/ui/views/controls/c...
ui/views/controls/combobox/native_combobox_views.cc:327: combobox_->invalid() ?
ui::NativeTheme::kColorId_LabelDisabledColor :
this broke the code. For my desktop chromeos build, LabelDisabledColor is not
white, or close to white. It is close to black, and not visible on a red
background.

[Elliot Glaysher, 2013-05-01 23:23:20]

https://chromiumcodereview.appspot.com/12395034/diff/2001/ui/views/controls/c...
File ui/views/controls/combobox/native_combobox_views.cc (right):

https://chromiumcodereview.appspot.com/12395034/diff/2001/ui/views/controls/c...
ui/views/controls/combobox/native_combobox_views.cc:327: combobox_->invalid() ?
ui::NativeTheme::kColorId_LabelDisabledColor :
On 2013/05/01 23:18:50, Evan Stade wrote:
> this broke the code. For my desktop chromeos build, LabelDisabledColor is not
> white, or close to white. It is close to black, and not visible on a red
> background.

Desktop chromeos shouldn't be using NativeThemeGtk2 instances. Is that what's
going on?

[Evan Stade, 2013-05-01 23:28:44]

https://chromiumcodereview.appspot.com/12395034/diff/2001/ui/views/controls/c...
File ui/views/controls/combobox/native_combobox_views.cc (right):

https://chromiumcodereview.appspot.com/12395034/diff/2001/ui/views/controls/c...
ui/views/controls/combobox/native_combobox_views.cc:327: combobox_->invalid() ?
ui::NativeTheme::kColorId_LabelDisabledColor :
On 2013/05/01 23:23:20, Elliot Glaysher wrote:
> On 2013/05/01 23:18:50, Evan Stade wrote:
> > this broke the code. For my desktop chromeos build, LabelDisabledColor is
not
> > white, or close to white. It is close to black, and not visible on a red
> > background.
> 
> Desktop chromeos shouldn't be using NativeThemeGtk2 instances. Is that what's
> going on?

no. LabelDisabledColor is just not the right color here (the combobox is not
disabled).