Issue 12395019: Merge 185407

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12395019: Merge 185407 (Closed)

Created:
7 years, 9 months ago by jwd

Modified:
7 years, 9 months ago

Reviewers:
jwd

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

More Reviews

Description

Merge 185407 > Improving histogram logging for the signin histogram. > > Creating new histograms for all the ways to get into the sign in flow, including one click sign in. Also making sure all the histogram logging is correct. > > > BUG=174759 > TEST=Try different sign in flows, ensure that appropriate histograms appear in about:histograms. Histograms should be Signin.*Actions. > > Review URL: https://chromiumcodereview.appspot.com/12362002 TBR=jwd@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185922

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -30 lines)			Patch
	M	chrome/browser/ui/sync/one_click_signin_helper.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/sync/one_click_signin_helper.cc	View		17 chunks	+109 lines, -30 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r185922.

Expand Messages | Collapse Messages