Added support for non-separable blending modes and fixed scalar issue

Added support for non-separable blending modes.
Fixed scalar issue from https://codereview.appspot.com/7346044

Committed: http://code.google.com/p/skia/source/detail?r=7984

[reed1, 2013-03-04 19:01:15]

cc1plus: warnings being treated as errors
/skia2/trunk/gyp/../src/core/SkXfermode.cpp: In function 'void SetSat(int*,
int*, int*, float)':
/skia2/trunk/gyp/../src/core/SkXfermode.cpp:468: warning: passing 'float' for
argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
/skia2/trunk/gyp/../src/core/SkXfermode.cpp:470: warning: passing 'float' for
argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
/skia2/trunk/gyp/../src/core/SkXfermode.cpp:472: warning: passing 'float' for
argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
/skia2/trunk/gyp/../src/core/SkXfermode.cpp:475: warning: passing 'float' for
argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
/skia2/trunk/gyp/../src/core/SkXfermode.cpp:477: warning: passing 'float' for
argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
/skia2/trunk/gyp/../src/core/SkXfermode.cpp:479: warning: passing 'float' for
argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'

Lets find a way for you to build w/ these warnings enabled.

[RikC, 2013-03-04 19:02:53]

On 2013/03/04 19:01:15, reed1 wrote:
> cc1plus: warnings being treated as errors
> /skia2/trunk/gyp/../src/core/SkXfermode.cpp: In function 'void SetSat(int*,
> int*, int*, float)':
> /skia2/trunk/gyp/../src/core/SkXfermode.cpp:468: warning: passing 'float' for
> argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> /skia2/trunk/gyp/../src/core/SkXfermode.cpp:470: warning: passing 'float' for
> argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> /skia2/trunk/gyp/../src/core/SkXfermode.cpp:472: warning: passing 'float' for
> argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> /skia2/trunk/gyp/../src/core/SkXfermode.cpp:475: warning: passing 'float' for
> argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> /skia2/trunk/gyp/../src/core/SkXfermode.cpp:477: warning: passing 'float' for
> argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> /skia2/trunk/gyp/../src/core/SkXfermode.cpp:479: warning: passing 'float' for
> argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> 
> Lets find a way for you to build w/ these warnings enabled.

I uploaded a fix and will try to execute this on my mac too.

[RikC, 2013-03-04 20:29:19]

On 2013/03/04 19:02:53, cabanier wrote:
> On 2013/03/04 19:01:15, reed1 wrote:
> > cc1plus: warnings being treated as errors
> > /skia2/trunk/gyp/../src/core/SkXfermode.cpp: In function 'void SetSat(int*,
> > int*, int*, float)':
> > /skia2/trunk/gyp/../src/core/SkXfermode.cpp:468: warning: passing 'float'
for
> > argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> > /skia2/trunk/gyp/../src/core/SkXfermode.cpp:470: warning: passing 'float'
for
> > argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> > /skia2/trunk/gyp/../src/core/SkXfermode.cpp:472: warning: passing 'float'
for
> > argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> > /skia2/trunk/gyp/../src/core/SkXfermode.cpp:475: warning: passing 'float'
for
> > argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> > /skia2/trunk/gyp/../src/core/SkXfermode.cpp:477: warning: passing 'float'
for
> > argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> > /skia2/trunk/gyp/../src/core/SkXfermode.cpp:479: warning: passing 'float'
for
> > argument 4 to 'void setSaturationComponents(int*, int*, int*, int)'
> > 
> > Lets find a way for you to build w/ these warnings enabled.
> 
> I uploaded a fix and will try to execute this on my mac too.

I installed this patch on my mac and it built with no errors.

[reed1, 2013-03-04 20:44:08]

lgtm

I will land this, but after the current set of rebaselines, since this CL will
cause us to rebaseline all instances of xfermodes (since it adds 4 more modes)

[commit-bot: I haz the power, 2013-03-05 16:23:55]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/cabanier@gmail.com/12393049/6001

[commit-bot: I haz the power, 2013-03-05 16:24:00]

Change committed as 7984