Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 12393045: Logging: pass through logging for devtools page (although it has no UI bindings). (Closed)

Created:
7 years, 9 months ago by pfeldman
Modified:
7 years, 9 months ago
Reviewers:
Charlie Reis, jam, yurys
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Logging: pass through logging for devtools page (although it has no UI bindings). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186243

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pfeldman
7 years, 9 months ago (2013-03-04 14:44:46 UTC) #1
Dmitry Polukhin
LGTM
7 years, 9 months ago (2013-03-04 14:51:29 UTC) #2
pfeldman
@John: stamp needed
7 years, 9 months ago (2013-03-04 14:57:33 UTC) #3
jam
I'm not really familiar with this (although it seems trivial). redirecting to creis
7 years, 9 months ago (2013-03-04 18:05:16 UTC) #4
Charlie Reis
Looks like we're limiting how much WebUI pages log to the console, and this just ...
7 years, 9 months ago (2013-03-04 18:34:21 UTC) #5
yurys
lgtm
7 years, 9 months ago (2013-03-05 15:33:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/12393045/1
7 years, 9 months ago (2013-03-05 16:41:28 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-05 20:27:04 UTC) #8
Message was sent while issue was closed.
Change committed as 186243

Powered by Google App Engine
This is Rietveld 408576698