Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 12391056: Remove Aura's extra shadowed border in the new dialog style. (Closed)

Created:
7 years, 9 months ago by msw
Modified:
7 years, 9 months ago
CC:
chromium-reviews, tfarina, Mike Wittman, Daniel Erat
Visibility:
Public.

Description

Remove Aura's extra shadowed border in the new dialog style. Set new Aura dialogs' corewm::ShadowType to SHADOW_TYPE_NONE. Removes the extra frame around new style dialogs on CrOS. ( does the same on the experimental Windows ash_shell ) See http://crbug.com/166075#c37 for before/after screenshots. This doesn't remove the black dialog border on Win. ( non-transparency is required to host native controls ) BUG=166075 TEST=CrOS --enable-new-dialog-style looks nicer. R=sky@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190030

Patch Set 1 : Simplify; use a TYPE_BUBBLE Widget for the new dialog style. #

Patch Set 2 : Remove NativeWidgetAura's shadow via InitParams::remove_standard_frame. #

Patch Set 3 : Remove NativeWidgetAura's shadow in DialogDelegate Widget construction. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ui/views/window/dialog_delegate.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 9 months ago (2013-03-20 20:59:37 UTC) #1
sky
It seems rather confusing that we have dialogs treated as bubbles. Is there some other ...
7 years, 9 months ago (2013-03-20 21:39:42 UTC) #2
msw
On 2013/03/20 21:39:42, sky wrote: > It seems rather confusing that we have dialogs treated ...
7 years, 9 months ago (2013-03-20 21:57:24 UTC) #3
tfarina
On Wed, Mar 20, 2013 at 6:57 PM, <msw@chromium.org> wrote: > Note that I'm not ...
7 years, 9 months ago (2013-03-20 22:00:24 UTC) #4
Ben Goodger (Google)
indeed. we should not change type for a different presentation. instead we should separate presentation ...
7 years, 9 months ago (2013-03-20 22:03:54 UTC) #5
msw
On 2013/03/20 22:03:54, Ben Goodger (Google) wrote: > indeed. we should not change type for ...
7 years, 9 months ago (2013-03-20 22:13:34 UTC) #6
Ben Goodger (Google)
I think windows should have the correct type. The type triggers behavioral and appearance traits. ...
7 years, 9 months ago (2013-03-20 23:46:26 UTC) #7
msw
On 2013/03/20 23:46:26, Ben Goodger (Google) wrote: > I think windows should have the correct ...
7 years, 9 months ago (2013-03-21 00:21:51 UTC) #8
msw
Please take another look; you may also consider Patch Set 2.
7 years, 9 months ago (2013-03-21 18:13:52 UTC) #9
Ben Goodger (Google)
lgtm
7 years, 9 months ago (2013-03-21 18:20:39 UTC) #10
Ben Goodger (Google)
It could even be that the NCFVs have different _behavior_ (not sure, haven't looked at ...
7 years, 9 months ago (2013-03-21 18:21:40 UTC) #11
msw
On 2013/03/21 18:21:40, Ben Goodger (Google) wrote: > It could even be that the NCFVs ...
7 years, 9 months ago (2013-03-21 18:51:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12391056/47002
7 years, 9 months ago (2013-03-21 18:52:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12391056/47002
7 years, 9 months ago (2013-03-21 22:42:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12391056/47002
7 years, 9 months ago (2013-03-22 16:15:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12391056/47002
7 years, 9 months ago (2013-03-22 18:13:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12391056/47002
7 years, 9 months ago (2013-03-23 14:43:50 UTC) #17
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 16:39:02 UTC) #18
Message was sent while issue was closed.
Change committed as 190030

Powered by Google App Engine
This is Rietveld 408576698